You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/07/31 23:35:24 UTC
[GitHub] incubator-brooklyn pull request: Fix/rebind machine lifecycle effe...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/786
Fix/rebind machine lifecycle effector tasks
As discussed in https://github.com/apache/incubator-brooklyn/pull/763.
Fixes backwards compatibility failure in persistence by re-adding the anonymous inner classes to `MachineLifecycleEffectorTasks` (but they are no longer instantiated, so new things will use the new class names).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/rebind-MachineLifecycleEffectorTasks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #786
----
commit 429a27dd091a3d1da73d3dba694ae16b9890f87b
Author: Aled Sage <al...@gmail.com>
Date: 2015-07-31T21:02:52Z
Handle SoftwareProcess.lifecycleEffectorTasks being null
If null, then default to the usual SoftwareProcessDriverLifecycleEffectorTasks.
commit cda7eade0586c0758593cfe04554d1e6ae830713
Author: Aled Sage <al...@gmail.com>
Date: 2015-07-31T21:03:39Z
MachineLifecycleEffectorTasks backwards compatibility
Add back in the anonymous inner classes for
new(Start|Stop|Restart)EffectorTask
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/rebind machine lifecycle effe...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/786#issuecomment-127781843
Thanks @neykov - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/rebind machine lifecycle effe...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/786#issuecomment-127180911
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/rebind machine lifecycle effe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/786
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---