You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/12/23 21:48:46 UTC
[GitHub] [lucene-solr] tflobbe opened a new pull request #1116: SOLR-14135:
Utils.toJavabin returns a byte[] instead of InputStream
tflobbe opened a new pull request #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream
URL: https://github.com/apache/lucene-solr/pull/1116
I'm not too convinced about this PR honestly, I started thinking in doing this mostly because in the 8x branch we can't use InputStream's `readAllBytes();` method, but this may actually hurt future consumers of this method, if they don't need to read all bytes at once. I'll leave this PR for now, worst case I'll keep the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on issue #1116: SOLR-14135:
Utils.toJavabin returns a byte[] instead of InputStream
Posted by GitBox <gi...@apache.org>.
noblepaul commented on issue #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream
URL: https://github.com/apache/lucene-solr/pull/1116#issuecomment-568863673
You can create another method with the appropriate return type, correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on issue #1116: SOLR-14135:
Utils.toJavabin returns a byte[] instead of InputStream
Posted by GitBox <gi...@apache.org>.
tflobbe commented on issue #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream
URL: https://github.com/apache/lucene-solr/pull/1116#issuecomment-570292700
Yes, the thing is that this method is not being used anywhere else at this time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe edited a comment on issue #1116: SOLR-14135:
Utils.toJavabin returns a byte[] instead of InputStream
Posted by GitBox <gi...@apache.org>.
tflobbe edited a comment on issue #1116: SOLR-14135: Utils.toJavabin returns a byte[] instead of InputStream
URL: https://github.com/apache/lucene-solr/pull/1116#issuecomment-570292700
Yes, the thing is that this method is not being used anywhere else at this time, so the `InputStream` one would be unused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org