[GitHub] jihoonson commented on a change in pull request #7048: Make IngestSegmentFirehoseFactory splittable for parallel ingestion

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7048: Make IngestSegmentFirehoseFactory splittable for parallel ingestion
URL: https://github.com/apache/incubator-druid/pull/7048#discussion_r261448493
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/WindowedSegment.java
 ##########
 @@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.indexing.firehose;
+
+import org.apache.druid.timeline.DataSegment;
+import org.joda.time.Interval;
+
+import javax.annotation.Nullable;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * A WindowedSegment represents a segment plus the list of intervals inside it which contribute to a timeline.
+ * If the list of intervals is null, the entire segment contributes to the timeline.
+ *
+ * This class is intended for in-memory use; WindowedSegmentId is better for serializing in specs.
+ */
+public class WindowedSegment
 
 Review comment:
   The goal of this class looks similar to `TimelineObjectHolder`. `TimelineObjectHolder` is to represent each non-overshadowed logical segment backed by a real segment which might be partially overshadowed. `WindowedSegment` is opposite: It represents a real segment and what intervals are not overshadowed. Can we reuse `TimelineObjectHolder`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org