You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemml.apache.org by ni...@apache.org on 2018/02/01 22:41:03 UTC
systemml git commit: [SYSTEMML-445] Disable ternary aggregate rewrite
on GPU backend
Repository: systemml
Updated Branches:
refs/heads/master 5da8132ea -> ad5275932
[SYSTEMML-445] Disable ternary aggregate rewrite on GPU backend
- This issue will be revisited when we add tack+ and tak+ kernels.
Project: http://git-wip-us.apache.org/repos/asf/systemml/repo
Commit: http://git-wip-us.apache.org/repos/asf/systemml/commit/ad527593
Tree: http://git-wip-us.apache.org/repos/asf/systemml/tree/ad527593
Diff: http://git-wip-us.apache.org/repos/asf/systemml/diff/ad527593
Branch: refs/heads/master
Commit: ad5275932e9d74fc4c980757c1ef8e94b6ea04e1
Parents: 5da8132
Author: Niketan Pansare <np...@us.ibm.com>
Authored: Thu Feb 1 14:40:34 2018 -0800
Committer: Niketan Pansare <np...@us.ibm.com>
Committed: Thu Feb 1 14:40:34 2018 -0800
----------------------------------------------------------------------
src/main/java/org/apache/sysml/hops/AggUnaryOp.java | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/systemml/blob/ad527593/src/main/java/org/apache/sysml/hops/AggUnaryOp.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/hops/AggUnaryOp.java b/src/main/java/org/apache/sysml/hops/AggUnaryOp.java
index 9b9406a..79c1610 100644
--- a/src/main/java/org/apache/sysml/hops/AggUnaryOp.java
+++ b/src/main/java/org/apache/sysml/hops/AggUnaryOp.java
@@ -551,6 +551,10 @@ public class AggUnaryOp extends Hop implements MultiThreadedHop
{
boolean ret = false;
+ // TODO: Disable ternary aggregate rewrite on GPU backend.
+ if(DMLScript.USE_ACCELERATOR)
+ return false;
+
//currently we support only sum over binary multiply but potentially
//it can be generalized to any RC aggregate over two common binary operations
if( OptimizerUtils.ALLOW_SUM_PRODUCT_REWRITES && _op == AggOp.SUM &&