You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2024/01/23 08:18:26 UTC
[kudu-CR] KUDU-3535 Should clear log cache while tombstoning a replica.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20822 )
Change subject: KUDU-3535 Should clear log cache while tombstoning a replica.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20822/3/src/kudu/consensus/log_cache.cc
File src/kudu/consensus/log_cache.cc:
http://gerrit.cloudera.org:8080/#/c/20822/3/src/kudu/consensus/log_cache.cc@480
PS3, Line 480: void LogCache::Clear() {
: tracker_->Release(tracker_->consumption());
: cache_.clear();
: }
Could you give some unit tests to verify this case?
--
To view, visit http://gerrit.cloudera.org:8080/20822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf545e604f80d41e7ebd9660acfd2e928cd27a9
Gerrit-Change-Number: 20822
Gerrit-PatchSet: 3
Gerrit-Owner: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:18:26 +0000
Gerrit-HasComments: Yes