[jira] [Resolved] (SOLR-4514) Need tests for OpenExchangeRatesOrgProvider

["Mike Drob (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Drob resolved SOLR-4514.
-----------------------------
       Resolution: Fixed
         Assignee: Hoss Man
    Fix Version/s: 4.2

> Need tests for OpenExchangeRatesOrgProvider
> -------------------------------------------
>
>                 Key: SOLR-4514
>                 URL: https://issues.apache.org/jira/browse/SOLR-4514
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 4.2
>
>         Attachments: SOLR-4514.patch, SOLR-4514.patch
>
>
> the schema.xml used by CurrencyFieldTest declares a fieldType named "openexchangeratesorg_currency" using OpenExchangeRatesOrgProvider pointed at a local copy of open-exchange-rates.json, but field type is completley unused, so nothing about this provider's behavior is ever really tested.
> We should change the test such that all of the functionality tested against the "amount" field is also tested against some new field using this OER provider based fieldType, where the copied data (and static exchange rates) are identical.
> (esasiest way would probably be to introduce a test variable for the field name and let a new subclass override it)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org