[GitHub] [ozone] umamaheswararao commented on a diff in pull request #3645: HDDS-7039. EC: Handle the placement policy check in ECUnderReplicationHandler

[GitBox <gi...@apache.org>]

umamaheswararao commented on code in PR #3645:
URL: https://github.com/apache/ozone/pull/3645#discussion_r979538738


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -234,6 +234,19 @@ public HddsProtos.NodeOperationalState getPersistedOpState() {
     }
   }
 
+  /**
+   * Checks if the OperationalState is Node is Decomissioned or Decomissioning.
+   * @return True if OperationalState is Decommissioned or Decomissioning.
+   */
+  public boolean isDecomissioned() {
+    return this.getPersistedOpState() ==
+            HddsProtos.NodeOperationalState.DECOMMISSIONED ||
+            this.getPersistedOpState() ==
+            HddsProtos.NodeOperationalState.DECOMMISSIONING;
+  }

Review Comment:
   Could you please avoid this multiple empty lines?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org