[jira] [Commented] (LUCENE-4147) rollback/preparecommit thread hazard

["Simon Willnauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13395826#comment-13395826 ] 

Simon Willnauer commented on LUCENE-4147:
-----------------------------------------

mike, do we really need to acquire the commit lock? from my perspective it would be enough to add an ensure open when we assigne pendingCommit (inside the sync block) so that racing threads hit already close exceptions.

regarding the thread safety issue in DocWriter can you paste the trace?

                
> rollback/preparecommit thread hazard
> ------------------------------------
>
>                 Key: LUCENE-4147
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4147
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>         Attachments: LUCENE-4147.patch, LUCENE-4147.patch
>
>
> found by http://jenkins.sd-datasolutions.de/job/Lucene-Solr-4.x-Windows-Java7-64/70/
> rollback should never throw this exception, as it documents it clears any pendingcommits.
> but it calls closeInternal outside of any sync block, so it looks like there is a race here.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org