You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/28 18:24:43 UTC
Re: Review Request 58048: Added id to Resource.DiskInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review183960
-----------------------------------------------------------
src/common/resources.cpp
Line 187 (original), 187 (patched)
<https://reviews.apache.org/r/58048/#comment260003>
We also need to update `addable` and `subtractable` similar to what we did for persistent volumes.
Depending on the "disk" source type, the semantics is different:
1. RAW w/ id:
- Cannot be split into smaller pieces
- Cannot be merged even if they are equal
2. RAW w/o id:
- Can be split into smaller pieces
- Can be merged if RAW parts equal
3. PATH w/ id:
- Can be split into smaller pieces
- Can be merged if PATH parts equal
4. PATH w/o id:
- Same as PATH w/ id
5. MOUNT w/ id:
- Cannot be split into smaller pieces
- Cannot be merged even if they are equal
6. MOUNT w/o id:
- Same as MOUNT w/ id
- Jie Yu
On May 19, 2017, 9:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 9:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e138e2aedb1369acdde82facf9dfea9780411154
> include/mesos/v1/mesos.proto ab617bfd2bc46e44f7d71cefecf5eac3630d22b3
> src/common/resources.cpp 1d07f1a049ba3bb3f5d78f05031f33ba97e07e8c
> src/tests/mesos.hpp 3c57f25ff0bec55582b8a7decef53be61a9ec6f4
> src/tests/resources_tests.cpp 5dcbce2dd4944194b59790551929d6d75b805ba3
> src/v1/resources.cpp 1bb5d0741c9f9ea59f34e92159a335661019444d
>
>
> Diff: https://reviews.apache.org/r/58048/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 58048: Added 'id' and 'metadata' fields to
'Resource.DiskInfo.Source'.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Aug. 28, 2017, 8:24 p.m., Jie Yu wrote:
> > src/common/resources.cpp
> > Line 187 (original), 187 (patched)
> > <https://reviews.apache.org/r/58048/diff/4/?file=1725749#file1725749line187>
> >
> > We also need to update `addable` and `subtractable` similar to what we did for persistent volumes.
> >
> > Depending on the "disk" source type, the semantics is different:
> > 1. RAW w/ id:
> > - Cannot be split into smaller pieces
> > - Cannot be merged even if they are equal
> > 2. RAW w/o id:
> > - Can be split into smaller pieces
> > - Can be merged if RAW parts equal
> > 3. PATH w/ id:
> > - Can be split into smaller pieces
> > - Can be merged if PATH parts equal
> > 4. PATH w/o id:
> > - Same as PATH w/ id
> > 5. MOUNT w/ id:
> > - Cannot be split into smaller pieces
> > - Cannot be merged even if they are equal
> > 6. MOUNT w/o id:
> > - Same as MOUNT w/ id
I updated the code to follow these semantics. You did not mention `BLOCK` sources above; I gave them the same semantics as `RAW` sources.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review183960
-----------------------------------------------------------
On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2017, 3:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c
> include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5
> src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade
> src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc
> src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb
>
>
> Diff: https://reviews.apache.org/r/58048/diff/5/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>