You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zhijiang (JIRA)" <ji...@apache.org> on 2018/06/21 10:30:00 UTC
[jira] [Commented] (FLINK-9636) Network buffer leaks in requesting
a batch of segments during canceling
[ https://issues.apache.org/jira/browse/FLINK-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519204#comment-16519204 ]
zhijiang commented on FLINK-9636:
---------------------------------
[~NicoK], I think this is a bug during implementing credit-based flow control.
> Network buffer leaks in requesting a batch of segments during canceling
> -----------------------------------------------------------------------
>
> Key: FLINK-9636
> URL: https://issues.apache.org/jira/browse/FLINK-9636
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.6.0
> Reporter: zhijiang
> Priority: Major
>
> In {{NetworkBufferPool#requestMemorySegments}}, {{numTotalRequiredBuffers}} is increased {{numRequiredBuffers}} first.
> If {{InterruptedExeption}} is thrown during polling segments from the available queue, the requested segments will be recycled back to {{NetworkBufferPool}}, {{numTotalRequiredBuffers}} is decreased by the number of polled segments which is not inconsistent with {{numRequiredBuffers}}. So {{numTotalRequiredBuffers}} in {{NetworkBufferPool}} leaks in this case, and we can also decrease {{numRequiredBuffers}} to fix this bug.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)