You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/05/31 10:29:08 UTC

[GitHub] [submarine] MortalHappiness opened a new pull request #594: SUBMARINE-832. Broadcast events using eventBroadcaster

MortalHappiness opened a new pull request #594:
URL: https://github.com/apache/submarine/pull/594


   ### What is this PR for?
   Broadcast events using eventBroadcaster.
   
   References:
   1. https://github.com/kubernetes/sample-controller/blob/73e81dab82c945b087f7db1f1f4a7b50e7d92751/controller.go#L291
   2. https://github.com/kubernetes/sample-controller/blob/73e81dab82c945b087f7db1f1f4a7b50e7d92751/controller.go#L317
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-832
   
   ### How should this be tested?
   1. Create the namespace "submarine-user-test" before running operator
   2. Run the operator
   3. Create a submarine custom resource
   4. We can see the error event log from operator.
   
   ### Screenshots (if appropriate)
   
   ![image](https://user-images.githubusercontent.com/47914085/120180108-f68a8980-c23d-11eb-9a5c-7b9fd20ce721.png)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #594: SUBMARINE-832. Broadcast events using eventBroadcaster

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #594:
URL: https://github.com/apache/submarine/pull/594


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kevin85421 commented on pull request #594: SUBMARINE-832. Broadcast events using eventBroadcaster

Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #594:
URL: https://github.com/apache/submarine/pull/594#issuecomment-855412882


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #594: SUBMARINE-832. Broadcast events using eventBroadcaster

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #594:
URL: https://github.com/apache/submarine/pull/594#issuecomment-853988138


   @kevin85421 I've updated the description and attached a demo video.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #594: SUBMARINE-832. Broadcast events using eventBroadcaster

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #594:
URL: https://github.com/apache/submarine/pull/594#issuecomment-853988138


   @kevin85421 I've updated the description and attached a demo video.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org