You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "matrixji (via GitHub)" <gi...@apache.org> on 2023/03/12 10:51:09 UTC
[GitHub] [incubator-devlake-helm-chart] matrixji opened a new pull request, #94: feat: optional grafana install
matrixji opened a new pull request, #94:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/94
Fixes: #57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #94: feat: optional grafana install
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #94:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/94#issuecomment-1467412613
Some logs/screenshots from my local test.
### test without grafana
```
helm install lake . --set grafana.useExternal=true --set grafana.externalUrl="http://example.com"
```
```
❯ kubectl get all
NAME READY STATUS RESTARTS AGE
pod/lake-devlake-lake-0 1/1 Running 0 11m
pod/lake-devlake-mysql-0 1/1 Running 0 11m
pod/lake-devlake-ui-846ff6d68f-tft9w 1/1 Running 0 11m
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 3d23h
service/lake-devlake-lake ClusterIP 10.107.38.241 <none> 8080/TCP 11m
service/lake-devlake-mysql ClusterIP 10.102.101.16 <none> 3306/TCP 11m
service/lake-devlake-ui NodePort 10.111.15.81 <none> 4000:32001/TCP 11m
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/lake-devlake-ui 1/1 1 1 11m
NAME DESIRED CURRENT READY AGE
replicaset.apps/lake-devlake-ui-846ff6d68f 1 1 1 11m
NAME READY AGE
statefulset.apps/lake-devlake-lake 1/1 11m
statefulset.apps/lake-devlake-mysql 1/1 11m
```
And the dashboard link will navigate to example.com, which is 302 redirected by nginx in config-ui POD.
### Test without grafana use ingress
```
helm install lake . --set grafana.useExternal=true --set grafana.externalUrl="http://example.com" --set ingress.enabled=true --set ingress.hostname=host.docker.internal --set ingress.httpPort=30080 --set ingress.className=nginx
```
```
❯ kubectl get all
NAME READY STATUS RESTARTS AGE
pod/lake-devlake-lake-0 1/1 Running 0 9m50s
pod/lake-devlake-mysql-0 1/1 Running 0 9m50s
pod/lake-devlake-ui-846ff6d68f-tr9l6 1/1 Running 0 9m50s
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 4d
service/lake-devlake-lake ClusterIP 10.109.80.176 <none> 8080/TCP 9m50s
service/lake-devlake-mysql ClusterIP 10.102.169.73 <none> 3306/TCP 9m50s
service/lake-devlake-ui NodePort 10.110.127.79 <none> 4000:32001/TCP 9m50s
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/lake-devlake-ui 1/1 1 1 9m50s
NAME DESIRED CURRENT READY AGE
replicaset.apps/lake-devlake-ui-846ff6d68f 1 1 1 9m50s
NAME READY AGE
statefulset.apps/lake-devlake-lake 1/1 9m50s
statefulset.apps/lake-devlake-mysql 1/1 9m50s
❯ kubectl get ingress
NAME CLASS HOSTS ADDRESS PORTS AGE
lake-devlake nginx host.docker.internal 10.109.139.59 80 26s
lake-devlake-ext-grafana nginx host.docker.internal 10.109.139.59 80 26s
```
And in this case, the dashboard link is redirected by ingress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] likyh merged pull request #94: feat: optional grafana install
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh merged PR #94:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] daniel-hutao commented on pull request #94: feat: optional grafana install
Posted by "daniel-hutao (via GitHub)" <gi...@apache.org>.
daniel-hutao commented on PR #94:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/94#issuecomment-1467275898
Hello @matrixji, I have handled #86. I wanted to ask if you have tested your current pr locally? Is the 'selective installation of grafana' working correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] daniel-hutao commented on pull request #94: feat: optional grafana install
Posted by "daniel-hutao (via GitHub)" <gi...@apache.org>.
daniel-hutao commented on PR #94:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/94#issuecomment-1467243300
/hold
Wait for #86 be merged.
Hello @matrixji, thank you for your awsome words. Due to some refactoring on this chart in #86, merging this pr now would result in many conflicts. Considering that there are many more changes in #86, I would prefer to merge that pr first and then resolve conflicts with the current pr, which would make things much simpler. I apologize for not being able to merge your pr promptly, but I will try to merge #86 as soon as possible, and then come back here right away. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] daniel-hutao commented on pull request #94: feat: optional grafana install
Posted by "daniel-hutao (via GitHub)" <gi...@apache.org>.
daniel-hutao commented on PR #94:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/94#issuecomment-1475624378
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org