[GitHub] [qpid-proton-j] gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry.

[GitBox <gi...@apache.org>]

gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-605201737
 
 
   I had a look, and the module name addition itself seems fine, but I want to look into some odd behaviour around other manifest entries that get added after the change (yet on other pre-existing config seem like they should have been added previously) as well before putting the change in.
   
   Can I also ask why you did the override on the parent managed jar plugin version? Its obviously a little newer, but was there a specific reason to need to use it? If not I'd perhaps suggest removing that and just sticking to the managed version for simplicity and consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org