You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bigsnarfdude <gi...@git.apache.org> on 2014/07/23 05:12:43 UTC
[GitHub] spark pull request: PEP8 compliance
GitHub user bigsnarfdude opened a pull request:
https://github.com/apache/spark/pull/1540
PEP8 compliance
Just fixed some of the comments up for PEP8 compliance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bigsnarfdude/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit a83b187edebe2fd4038ffca751ea041867cadf13
Author: bigsnarfdude <oh...@gmail.com>
Date: 2014-07-23T03:07:28Z
PEP8 compliance
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: PEP8 compliance
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1540#issuecomment-49828604
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: PEP8 compliance
Posted by bigsnarfdude <gi...@git.apache.org>.
Github user bigsnarfdude commented on the pull request:
https://github.com/apache/spark/pull/1540#issuecomment-49828736
https://issues.apache.org/jira/browse/SPARK-2637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: PEP8 compliance
Posted by bigsnarfdude <gi...@git.apache.org>.
Github user bigsnarfdude closed the pull request at:
https://github.com/apache/spark/pull/1540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: PEP8 compliance
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1540#issuecomment-49907077
Jenkins, this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: PEP8 compliance
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1540#issuecomment-50247285
@bigsnarfdude Do you mind closing this pull request? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: PEP8 compliance
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1540#issuecomment-49836746
Thanks for submitting this. There was some discussion in https://github.com/apache/spark/pull/1505 that we opted not to modify cloudpickle so we can easily merge changes from it in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---