You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2016/01/10 18:25:08 UTC

Review Request 42116: HIVE-12824

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42116/
-----------------------------------------------------------

Review request for hive and Jesús Camacho Rodríguez.


Bugs: HIVE-12824
    https://issues.apache.org/jira/browse/HIVE-12824


Repository: hive-git


Description
-------

CBO doesnt get triggered when aggregate function is used within windowing function


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java b77beb8 
  ql/src/test/queries/clientpositive/windowing_gby.q b948f76 
  ql/src/test/results/clientpositive/groupby_resolution.q.out ea40014 
  ql/src/test/results/clientpositive/quotedid_basic.q.out 29736af 
  ql/src/test/results/clientpositive/tez/windowing_gby.q.out e65533f 

Diff: https://reviews.apache.org/r/42116/diff/


Testing
-------

windowing_gby.q


Thanks,

Ashutosh Chauhan

Re: Review Request 42116: HIVE-12824

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42116/#review113718
-----------------------------------------------------------

Ship it!


Ship It!

- Jesús Camacho Rodríguez


On Jan. 10, 2016, 5:25 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42116/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 5:25 p.m.)
> 
> 
> Review request for hive and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-12824
>     https://issues.apache.org/jira/browse/HIVE-12824
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> CBO doesnt get triggered when aggregate function is used within windowing function
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java b77beb8 
>   ql/src/test/queries/clientpositive/windowing_gby.q b948f76 
>   ql/src/test/results/clientpositive/groupby_resolution.q.out ea40014 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out 29736af 
>   ql/src/test/results/clientpositive/tez/windowing_gby.q.out e65533f 
> 
> Diff: https://reviews.apache.org/r/42116/diff/
> 
> 
> Testing
> -------
> 
> windowing_gby.q
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>