You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2016/05/31 14:40:12 UTC

[jira] [Commented] (OFBIZ-7144) Missing UiLabels for shortcuts in webpos

    [ https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307813#comment-15307813 ] 

Jacques Le Roux commented on OFBIZ-7144:
----------------------------------------

Thanks Amardeep,

I was curious about that so I checked and it's "a bit" more complicated (took me some time to sort it out). This is related with OFBIZ-6226 where Mridul Pathak committed in
    Trunk - r1720910
    14.12 - r1720916
    12.04 - r1720930

But there was duplicated labels so I partially reverted (only the duplicated labels) at
Trunk - r1726529
14.12 - r1726539
12.04 - r1726540

Later I noticed r1720910 was committed in Trunk before R15.12 creation, so I reverted there also at revision: 1729098, but not partially hence the inconsistency.  But actually I should have reverted all everywhere! In other words it's a chance that it works in R15.12, because this was initially due to "an error".

So I agree about your patches and they are committed at r1746283 for both R14.12 and trunk. I did not take care of R12.04

Remains that Mridul and Suraj were somewhere right. Like them (I guess) I don't like the names of the labels, I believe that (eg) WebPosCheckout is far better than WebPosShortcutF7. So they were partiallly wrong at OFBIZ-6226, they duplicated labels but the names would be better if they were not refering to keyboard keys numbers...



> Missing UiLabels for shortcuts in webpos
> ----------------------------------------
>
>                 Key: OFBIZ-7144
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7144
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/webpos
>    Affects Versions: Release Branch 14.12, Trunk
>            Reporter: Amardeep Singh Jhajj
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-7144-Release14.12.patch, OFBIZ-7144-ScreenShot.png, OFBIZ-7144-trunk.patch
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)