You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/09 14:47:36 UTC

[GitHub] [incubator-tvm] giuseros commented on a change in pull request #6864: Qnn for first conv

giuseros commented on a change in pull request #6864:
URL: https://github.com/apache/incubator-tvm/pull/6864#discussion_r519867264



##########
File path: tests/python/relay/test_pass_auto_quantize.py
##########
@@ -148,7 +148,7 @@ def verify_partition(mod, params):
         assert (
             len(unpartitioned_mod.get_global_vars()) == 1
         ), "unpartitioned module should only have one function"
-    with relay.quantize.qconfig(**BASE_CFG, partition_conversions="fully_integral"):
+    with relay.quantize.qconfig(**BASE_CFG):

Review comment:
       Just trying to understand this change. From what I read, the default `qconfig.partition_conversions` is `disabled`. Wouldn't this test be the same as the one on line 146?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org