You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/20 13:48:29 UTC

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1083: chore: remove Lua dependency

nic-chen opened a new pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   close #618 
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
    use Lua VM and compiler written in Go, so that we don't need to install Lua separately
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083#issuecomment-748610412


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=h1) Report
   > Merging [#1083](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=desc) (2e8f638) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cb1377cf9859392ee81ee60b3d4e623b1522be1e?el=desc) (cb1377c) will **decrease** coverage by `0.28%`.
   > The diff coverage is `76.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1083      +/-   ##
   ==========================================
   - Coverage   40.50%   40.22%   -0.29%     
   ==========================================
     Files          27       27              
     Lines        1627     1631       +4     
   ==========================================
   - Hits          659      656       -3     
   - Misses        873      877       +4     
   - Partials       95       98       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.66% <76.92%> (+0.06%)` | :arrow_up: |
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <0.00%> (-2.26%)` | :arrow_down: |
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=footer). Last update [cb1377c...2e8f638](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] tokers commented on pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083#issuecomment-748708105


   @nic-chen CI failed.
   ![image](https://user-images.githubusercontent.com/10428333/102730044-2cae0e00-436e-11eb-99ad-5a73bb37e5ac.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083#issuecomment-748610412


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=h1) Report
   > Merging [#1083](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=desc) (b2b8288) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cb1377cf9859392ee81ee60b3d4e623b1522be1e?el=desc) (cb1377c) will **decrease** coverage by `0.30%`.
   > The diff coverage is `57.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1083      +/-   ##
   ==========================================
   - Coverage   40.50%   40.19%   -0.31%     
   ==========================================
     Files          27       27              
     Lines        1627     1637      +10     
   ==========================================
   - Hits          659      658       -1     
   - Misses        873      879       +6     
   - Partials       95      100       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `45.77% <57.89%> (-0.83%)` | :arrow_down: |
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <0.00%> (-2.26%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=footer). Last update [cb1377c...b2b8288](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083#issuecomment-748714075


   @nic-chen Just to make sure, if we need to update any docs?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083#issuecomment-748610412


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=h1) Report
   > Merging [#1083](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=desc) (905f2f6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cb1377cf9859392ee81ee60b3d4e623b1522be1e?el=desc) (cb1377c) will **decrease** coverage by `0.23%`.
   > The diff coverage is `68.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1083      +/-   ##
   ==========================================
   - Coverage   40.50%   40.26%   -0.24%     
   ==========================================
     Files          27       27              
     Lines        1627     1634       +7     
   ==========================================
   - Hits          659      658       -1     
   - Misses        873      877       +4     
   - Partials       95       99       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.46% <68.75%> (-0.14%)` | :arrow_down: |
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <0.00%> (-2.26%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=footer). Last update [cb1377c...905f2f6](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083#issuecomment-748610412


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=h1) Report
   > Merging [#1083](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=desc) (0b5ea63) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cb1377cf9859392ee81ee60b3d4e623b1522be1e?el=desc) (cb1377c) will **decrease** coverage by `0.30%`.
   > The diff coverage is `57.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1083      +/-   ##
   ==========================================
   - Coverage   40.50%   40.19%   -0.31%     
   ==========================================
     Files          27       27              
     Lines        1627     1637      +10     
   ==========================================
   - Hits          659      658       -1     
   - Misses        873      879       +6     
   - Partials       95      100       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `45.77% <57.89%> (-0.83%)` | :arrow_down: |
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <0.00%> (-2.26%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=footer). Last update [cb1377c...0b5ea63](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083#issuecomment-748610412


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=h1) Report
   > Merging [#1083](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=desc) (b4ceb3e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/cb1377cf9859392ee81ee60b3d4e623b1522be1e?el=desc) (cb1377c) will **decrease** coverage by `0.22%`.
   > The diff coverage is `76.92%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1083      +/-   ##
   ==========================================
   - Coverage   40.50%   40.28%   -0.23%     
   ==========================================
     Files          27       27              
     Lines        1627     1631       +4     
   ==========================================
   - Hits          659      657       -2     
   - Misses        873      876       +3     
   - Partials       95       98       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.66% <76.92%> (+0.06%)` | :arrow_up: |
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1083/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `57.62% <0.00%> (-2.26%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=footer). Last update [cb1377c...b4ceb3e](https://codecov.io/gh/apache/apisix-dashboard/pull/1083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen merged pull request #1083: chore: remove Lua dependency

Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #1083:
URL: https://github.com/apache/apisix-dashboard/pull/1083


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org