You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "TherChenYang (via GitHub)" <gi...@apache.org> on 2024/03/18 11:48:18 UTC
[PR] Support SQLServer dml encrypt with schema [shardingsphere]
TherChenYang opened a new pull request, #30534:
URL: https://github.com/apache/shardingsphere/pull/30534
Fixes #30342.
Changes proposed in this pull request:
- Support SQLServer dml encrypt rewrite with schema
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support SQLServer dml encrypt with schema [shardingsphere]
Posted by "TherChenYang (via GitHub)" <gi...@apache.org>.
TherChenYang commented on code in PR #30534:
URL: https://github.com/apache/shardingsphere/pull/30534#discussion_r1530170933
##########
features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMergerTest.java:
##########
@@ -515,6 +515,16 @@ private ShardingSphereDatabase createDatabase() {
mock(RuleMetaData.class), Collections.singletonMap(DefaultDatabase.LOGIC_NAME, schema));
}
+ private ShardingSphereDatabase createSQLServerDatabase() {
Review Comment:
Thank you very much for your review,Because there is a default schema dbo in SQLServer,I will adjust the dataType here to SQLServer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support SQLServer dml encrypt with schema [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #30534:
URL: https://github.com/apache/shardingsphere/pull/30534#discussion_r1530140396
##########
features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/merge/dql/ShardingDQLResultMergerTest.java:
##########
@@ -515,6 +515,16 @@ private ShardingSphereDatabase createDatabase() {
mock(RuleMetaData.class), Collections.singletonMap(DefaultDatabase.LOGIC_NAME, schema));
}
+ private ShardingSphereDatabase createSQLServerDatabase() {
Review Comment:
Why is this method called createSQLServerDatabase, but MySQL is used internally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support SQLServer dml encrypt with schema [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #30534:
URL: https://github.com/apache/shardingsphere/pull/30534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org