You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/21 02:15:01 UTC

[GitHub] [echarts] pissang commented on a diff in pull request #16921: fix(custom): provide generic for itemStyle. close #16775

pissang commented on code in PR #16921:
URL: https://github.com/apache/echarts/pull/16921#discussion_r854719053


##########
src/chart/custom/CustomSeries.ts:
##########
@@ -338,7 +338,7 @@ export interface CustomSeriesOption extends
     /**
      * @deprecated
      */
-    itemStyle?: ItemStyleOption;
+    itemStyle?: ItemStyleOption<TCbParams>;

Review Comment:
   Could we use `CallbackDataParams` here as other series did?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org