You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Daniel Halperin (JIRA)" <ji...@apache.org> on 2016/11/02 22:49:58 UTC
[jira] [Created] (BEAM-887) Make FileBasedSink.getWriterResultCoder
abstract
Daniel Halperin created BEAM-887:
------------------------------------
Summary: Make FileBasedSink.getWriterResultCoder abstract
Key: BEAM-887
URL: https://issues.apache.org/jira/browse/BEAM-887
Project: Beam
Issue Type: Improvement
Components: sdk-java-core
Affects Versions: Not applicable
Reporter: Daniel Halperin
Assignee: Kenneth Knowles
Fix For: 0.4.0-incubating
FileBasedSink has this function:
{code}
/**
* Returns a coder for the writer result type.
*/
public Coder<WriteT> getWriterResultCoder() {
return null;
}
{code}
It returns {{null}} by default, but in practice if this happens then building the pipeline will crash with a {{NullPointerException}}. Now that we can make backward-incompatible changes, just make it abstract and force implementations to add this method. (All implementations already implement it already.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)