[jira] [Commented] (SMX4-1270) Velocity bundle has flawed OSGi MANIFEST.MF

["Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SMX4-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498929#comment-13498929 ] 

Jean-Baptiste Onofré commented on SMX4-1270:
--------------------------------------------

There is not problem "globally" to the bundles. The packages marked as optional in the MANIFEST ARE defined as optional in the pom.xml. So no problem around that. So the generated MANIFEST is correct and aligned with the pom.

However, some packages should not be set as optional (like oro or jdom) as it's used by velocity internally.
                
> Velocity bundle has flawed OSGi MANIFEST.MF
> -------------------------------------------
>
>                 Key: SMX4-1270
>                 URL: https://issues.apache.org/jira/browse/SMX4-1270
>             Project: ServiceMix 4
>          Issue Type: Task
>          Components: Bundles
>            Reporter: Claus Ibsen
>            Assignee: Jean-Baptiste Onofré
>            Priority: Critical
>
> The 1.7 bundles of Apache Velocity at
> http://repo2.maven.org/maven2/org/apache/servicemix/bundles/org.apache.servicemix.bundles.velocity/
> Has wrong MANIFEST.MF imports.
> For example if you look at the latest 1.7.0_5
> http://repo2.maven.org/maven2/org/apache/servicemix/bundles/org.apache.servicemix.bundles.velocity/1.7_5/org.apache.servicemix.bundles.velocity-1.7_5.pom
> In the bottom of this pom.xml file noticed the imports for commons-collection and commons-lang is mandatory (they dont have optional).
> But in the generated JAR the MANIFEST.MF contains the following
> {code}
> Import-Package: com.werken.xpath;resolution:=optional;version="[0.9.4,1)
>  ",javax.servlet;resolution:=optional;version="[2.3,3)",javax.servlet.ht
>  tp;resolution:=optional;version="[2.3,3)",org.apache.commons.collection
>  s;version="[3.2,4)";resolution:=optional,org.apache.commons.collections
>  .map;version="[3.2,4)";resolution:=optional,org.apache.commons.lang;ver
>  sion="[2.4,3)";resolution:=optional,org.apache.commons.lang.builder;ver
>  sion="[2.4,3)";resolution:=optional,org.apache.commons.lang.text;versio
>  n="[2.4,3)";resolution:=optional,org.apache.commons.logging;resolution:
>  =optional;version="[1.1,2)",org.apache.log;resolution:=optional;version
>  ="[2,3)",org.apache.log.format;resolution:=optional;version="[2,3)",org
>  .apache.log.output.io;resolution:=optional;version="[2,3)",org.apache.l
>  og4j;resolution:=optional;version="[2,3)",org.apache.oro.text.perl;reso
>  lution:=optional,org.apache.tools.ant;resolution:=optional;version="[1.
>  6,2)",org.apache.tools.ant.taskdefs;resolution:=optional;version="[1.6,
>  2)",org.jdom;resolution:=optional;version="[1,2)",org.jdom.input;resolu
>  tion:=optional;version="[1,2)",org.jdom.output;resolution:=optional;ver
>  sion="[1,2)"
> {code}
> Now notice that almost all the imports is now optional. This is now what we specified in the pom.xml file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira