You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by philipphoffmann <gi...@git.apache.org> on 2017/01/31 13:48:14 UTC
[GitHub] spark pull request #16755: [MESOS] Support constraints in spark-dispatcher
GitHub user philipphoffmann opened a pull request:
https://github.com/apache/spark/pull/16755
[MESOS] Support constraints in spark-dispatcher
The `MesosClusterScheduler` doesn't handle the `spark.mesos.constraints`
setting (as opposed to `MesosCoarseGrainedSchedulerBackend`).
## What changes were proposed in this pull request?
This commit introduces the necessary changes to handle the offer
constraints.
## How was this patch tested?
unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/philipphoffmann/spark fix-dispatcher-constraints
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16755
----
commit 551a593949475abcb40414e03d7b01e04c5932f3
Author: Philipp Hoffmann <ma...@philipphoffmann.de>
Date: 2017-01-31T13:42:04Z
[MESOS] Support constraints in spark-dispatcher
The `MesosClusterScheduler` doesn't handle the `spark.mesos.constraints`
setting (as opposed to `MesosCoarseGrainedSchedulerBackend`).
This commit introduces the necessary changes to handle the offer
constraints.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [SPARK-19606][MESOS] Support constraints in spark-dispat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16755
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74530/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [SPARK-19606][MESOS] Support constraints in spark-dispat...
Posted by philipphoffmann <gi...@git.apache.org>.
Github user philipphoffmann commented on the issue:
https://github.com/apache/spark/pull/16755
rebase to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [MESOS] Support constraints in spark-dispatcher
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16755
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [SPARK-19606][MESOS] Support constraints in spark-dispat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16755
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [SPARK-19606][MESOS] Support constraints in spark-dispat...
Posted by philipphoffmann <gi...@git.apache.org>.
Github user philipphoffmann commented on the issue:
https://github.com/apache/spark/pull/16755
Created a Jira and linked it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [MESOS] Support constraints in spark-dispatcher
Posted by skonto <gi...@git.apache.org>.
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/16755
Please fix the title for the PR and include the related jira issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [SPARK-19606][MESOS] Support constraints in spark-dispat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16755
**[Test build #74530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74530/testReport)** for PR 16755 at commit [`ae861d4`](https://github.com/apache/spark/commit/ae861d4af741dc9eaa5205bfa7ef5134e97cde39).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [MESOS] Support constraints in spark-dispatcher
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16755
**[Test build #72198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72198/testReport)** for PR 16755 at commit [`551a593`](https://github.com/apache/spark/commit/551a593949475abcb40414e03d7b01e04c5932f3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [MESOS] Support constraints in spark-dispatcher
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16755
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72198/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [MESOS] Support constraints in spark-dispatcher
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16755
**[Test build #72198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72198/testReport)** for PR 16755 at commit [`551a593`](https://github.com/apache/spark/commit/551a593949475abcb40414e03d7b01e04c5932f3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [SPARK-19606][MESOS] Support constraints in spark-dispat...
Posted by aroundthecode <gi...@git.apache.org>.
Github user aroundthecode commented on the issue:
https://github.com/apache/spark/pull/16755
Any hope to see this resolved ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16755: [SPARK-19606][MESOS] Support constraints in spark-dispat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16755
**[Test build #74530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74530/testReport)** for PR 16755 at commit [`ae861d4`](https://github.com/apache/spark/commit/ae861d4af741dc9eaa5205bfa7ef5134e97cde39).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org