You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/05 02:07:29 UTC
[GitHub] [incubator-devlake] likyh opened a new pull request, #4108: fix: fix the style of version
likyh opened a new pull request, #4108:
URL: https://github.com/apache/incubator-devlake/pull/4108
### Summary
fix the style of version
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4108: fix: fix the style of version
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #4108:
URL: https://github.com/apache/incubator-devlake/pull/4108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4108: fix: fix the style of version
Posted by GitBox <gi...@apache.org>.
mintsweet commented on code in PR #4108:
URL: https://github.com/apache/incubator-devlake/pull/4108#discussion_r1062080750
##########
config-ui/src/layouts/base/base.tsx:
##########
@@ -76,8 +76,8 @@ export const BaseLayout = ({ children }: Props) => {
))}
</Menu>
<div className="copyright">
- <div>{version}</div>
<span>Apache 2.0 License</span>
+ <div>{version}</div>
Review Comment:
You can use `span` and add a class.
##########
config-ui/src/layouts/base/styled.ts:
##########
@@ -73,6 +73,12 @@ export const Sider = styled.div`
left: 0;
text-align: center;
color: rgba(124, 124, 124, 0.7);
+ padding: 0 20px;
+ div {
Review Comment:
Don't use div directly to add a class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org