You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "abhioncbr (via GitHub)" <gi...@apache.org> on 2023/04/08 02:41:42 UTC

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10540: Add opt ports to helm

abhioncbr commented on code in PR #10540:
URL: https://github.com/apache/pinot/pull/10540#discussion_r1161050806


##########
kubernetes/helm/pinot/templates/controller/service.yaml:
##########
@@ -31,5 +31,11 @@ spec:
     # [pod_name].[service_name].[namespace].svc.cluster.local
     - name: {{ .Values.controller.service.name }}
       port: {{ .Values.controller.service.port }}
+    {{- if .Values.controller.service.extraPorts }}

Review Comment:
   Minor, just for consistency, add `if` to all the other services for extra ports. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org