You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/07 20:51:05 UTC
[GitHub] [netbeans] KacerCZ opened a new pull request #2242: [NETBEANS-4185] Support for self return type
KacerCZ opened a new pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242
https://issues.apache.org/jira/browse/NETBEANS-4185
Added test files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mvorisek commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
mvorisek commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-972807852
Hi guys, I am the original reporter of the issue. I use NetBeans 12.2 and the issue seems still present.
When I uncomment the native return type in https://github.com/atk4/data/blob/3.0.0/src/Model/ReferencesTrait.php#L103 the more specific `Reference\ContainsOne` type from phpdoc is ignored, eg. no extra methods from it are hinted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-655134851
@tmysik @junichi11 There is problem if method has native return type `self` than `@return` annotation is not considered.
Objects `MethodScopeImpl` has set return type to `\self' and I can't find place where to use value from `@return`.
Method `FunctionScopeImpl::getReturnTypesDescriptor()` returns different value than in case when method has not native `self` return type.
Any advice how to fix this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-656991836
The reported bug is fixed.
I had wrong PHP test file - declaration of `A::returnSelf(): self` can't be overiden with `B::returnSelf(): self`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-656237641
@tmysik Yes, it is valid.
Type `static` is subtype of `self`. Using `self` as native return type is still better than leaving it out completely.
It is similar case as when you use type `array` in formal parameter and then use `@param \DateTime[]` to indicate that array should contain `\DateTime` objects.
PHP 8 will have native `static` return type - https://wiki.php.net/rfc/static_return_type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik merged pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-655199705
@KacerCZ Unfortunately, I can't provide something for it soon. (I have to read the source code to investigate the problem actually.) If you are not sure, I'll take over it later. If you would leave it to me, please let me know(please put on me to Assignee). Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-658813215
@junichi11 @tmysik Thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-656240519
@KacerCZ Great, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-656114599
@KacerCZ
Please, have you verified that the reported case is valid? I mean, it is some time now so I "left" the PHP world so just would like to get confirmed that it is a valid PHP (PhpDoc) use-case.
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2242: [NETBEANS-4185] Support for self return type
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2242:
URL: https://github.com/apache/netbeans/pull/2242#issuecomment-972814995
@mvorisek Please report your problem to the JIRA as a new issue with your exact steps to reproduce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists