You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/11/22 08:31:14 UTC
[jira] Created: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Don't replace the ProxyFactory classloaderProvider without the intention to do so
---------------------------------------------------------------------------------
Key: OWB-496
URL: https://issues.apache.org/jira/browse/OWB-496
Project: OpenWebBeans
Issue Type: Bug
Components: Context and Scopes
Affects Versions: 1.1.0
Reporter: David Jencks
Assignee: Gurkan Erdogdu
Fix For: 1.1.0
Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997454#comment-12997454 ]
Mark Struberg commented on OWB-496:
-----------------------------------
question: why is the fallback not _true_ by default?
or: why do we need this fallback at all?
The bug only have been that the ProxyFactory.classloaderProvider got changed and not subsequently resetted - resulting in an invalid behaviour.
But by _resetting_ it in the final block (btw, shouldn't we synchronize this?) this negative effect got fixed already, isn't?
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997903#comment-12997903 ]
Gerhard Petracek commented on OWB-496:
--------------------------------------
if there are no objections, i'll commit the attached patch by the end of the week.
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
> Attachments: OWB-496.patch
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg resolved OWB-496.
-------------------------------
Resolution: Fixed
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
> Attachments: OWB-496.patch
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934747#action_12934747 ]
Gurkan Erdogdu commented on OWB-496:
------------------------------------
Actually exception was related with ClassNFE or like this. I do not remember the exact case of using Thread CL but it was solved the problems that was related with javassist class loading issues.
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997655#comment-12997655 ]
Gurkan Erdogdu commented on OWB-496:
------------------------------------
We can do David's comment. We can create a SPI for returning Classloader for the ProxyFactory. At OWB startup we can update ProxyFactory.classsLoaderProvider with this. And revert the code to old version.
OWB_Startup{
ProxyFactyory.classLoaderProvider = SPI.getProxyFactoryLoader();
}
Revert code to
{
return SecurityUtil...
}
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek updated OWB-496:
---------------------------------
Attachment: OWB-496.patch
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
> Attachments: OWB-496.patch
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934409#action_12934409 ]
David Jencks commented on OWB-496:
----------------------------------
Fixed in rev 1037620
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978444#action_12978444 ]
David Jencks commented on OWB-496:
----------------------------------
I don't understand why you are pursuing this solution. In geronimo we simply install the classloader provider we want to use. Why can't you do this in the tomcat integration?
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997619#comment-12997619 ]
Gerhard Petracek commented on OWB-496:
--------------------------------------
i agree with mark. it looks quite strange and leads to many questions.
we also talked about introducing a spi for not forcing the usage of SecurityUtil
furthermore, in wls just the old version works correctly.
the rest works without problems -> i don't think it's a security issue.
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998293#comment-12998293 ]
Mark Struberg commented on OWB-496:
-----------------------------------
patch looks really good - I like the idea of just setting an own special ClassLoaderProvider which a) uses a ThreadLocal to work around the concurrency problems and b) provides our own plugable logic.
please go on and commit the patch. We will fine tune it later together if needed.
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
> Attachments: OWB-496.patch
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Mark Struberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997688#comment-12997688 ]
Mark Struberg commented on OWB-496:
-----------------------------------
David made a good point, and this is true for each of the proposed solutions as well as for the currently implemented one: Since this _dumb_ public static ProxyFactory.classloader is public, we would need to synchronize to prevent unintended behaviour in parallel executions :(
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978246#action_12978246 ]
Gurkan Erdogdu commented on OWB-496:
------------------------------------
see rev1055806.
I have added flag to openwebbean.properties with name "org.apache.webbeans.javassist.useClassLoaderProvider". Default is false, therefore if anybody wants to change classloaderpovider to Thread.ClassLoader, it must configure it. It means that current situtation has not effected.
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978230#action_12978230 ]
Gurkan Erdogdu commented on OWB-496:
------------------------------------
Problem is that,
In JavasisstProxyFactory # public ProxyFactory createProxyFactory(Bean<?> bean) throws Exception method, we add Serializable interface to the interface list. When Javassist would get ClassLoader, it executes the following statements in ProxyFactory
protected ClassLoader getClassLoader0() {
ClassLoader loader = null;
if (superClass != null && !superClass.getName().equals("java.lang.Object"))
loader = superClass.getClassLoader();
else if (interfaces != null && interfaces.length > 0)
loader = interfaces[0].getClassLoader();
if (loader == null) {
loader = getClass().getClassLoader();
// In case javassist is in the endorsed dir
if (loader == null) {
loader = Thread.currentThread().getContextClassLoader();
if (loader == null)
loader = ClassLoader.getSystemClassLoader();
}
}
return loader;
}
Here it looks interfaces[0] and it will be Serializable. Its classloader will be null. Therefore it gets classloader via getclass().getClassLoader(). It will be the server class loader if javassist.jar is located in server lib.
In Tomcat, we are getting ClassNotFoundException because, javassist.jar is located in tomcat/lib directory. That is the problem that I was trying to explain.
I will add flag or SPI for this.
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934663#action_12934663 ]
David Jencks commented on OWB-496:
----------------------------------
I don't understand your thinking. If you are in an environment where the thread context classloader is appropriate for creating proxies, why not just install it on startup? You have no idea what the cause of the exception here is. Once the classloader provider is replaced, there is no way to get back to the default one.
Do you have an example where the TCCL is a better choice than the classloader of the class being proxied?
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997613#comment-12997613 ]
David Jencks commented on OWB-496:
----------------------------------
I don't think anyone has tried to explain why its a good idea to flail around with unexpected exceptions rather than installing a classloader provider that is suitable for the environment OWB is running in.
I hope you don't synchronize a static or singleton method that is called very frequently from multiple threads. I think that would be required to make this exception handling code work.
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934463#action_12934463 ]
Gurkan Erdogdu commented on OWB-496:
------------------------------------
With this commit, OWB may not work! We can add configuration parameter to openwebbeans.properties file and defaults to true. So code is
catch(Exception e){
if(USE_JAVASSIST_EXCEPTION_CLASSLOADER){
Thread.current.....
}
}
Geronimo will provide parameter value as FALSE
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-496) Don't replace the ProxyFactory
classloaderProvider without the intention to do so
Posted by "Gerhard Petracek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OWB-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997847#comment-12997847 ]
Gerhard Petracek commented on OWB-496:
--------------------------------------
>prevent unintended behaviour in parallel executions
i agree with mark - that's one of the things i was referring to
> Don't replace the ProxyFactory classloaderProvider without the intention to do so
> ---------------------------------------------------------------------------------
>
> Key: OWB-496
> URL: https://issues.apache.org/jira/browse/OWB-496
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Context and Scopes
> Affects Versions: 1.1.0
> Reporter: David Jencks
> Assignee: Gurkan Erdogdu
> Fix For: 1.1.0
>
>
> Currently JavassistProxyFactory.getProxyClass() replaces the ProxyFactory.classloaderProvider on any exception with a classloaderProvider that is very unlikely to work better than the default. Setting the classLoaderProvider should be a matter of intentional configuration, not flailing around after an unexpected exception.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira