You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 12:58:27 UTC

[GitHub] [airflow] ashb commented on a change in pull request #13058: Set timeout for child processes

ashb commented on a change in pull request #13058:
URL: https://github.com/apache/airflow/pull/13058#discussion_r542362992



##########
File path: airflow/configuration.py
##########
@@ -69,7 +69,9 @@ def run_command(command):
     process = subprocess.Popen(
         shlex.split(command), stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True
     )
-    output, stderr = [stream.decode(sys.getdefaultencoding(), 'ignore') for stream in process.communicate()]
+    output, stderr = [
+        stream.decode(sys.getdefaultencoding(), 'ignore') for stream in process.communicate(timeout=60)

Review comment:
       I wonder if this one (and maybe some others) need to be configurable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org