You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/15 16:43:38 UTC

[GitHub] piyushghai commented on a change in pull request #12181: Fixed backwards compatibility checker

piyushghai commented on a change in pull request #12181: Fixed backwards compatibility checker
URL: https://github.com/apache/incubator-mxnet/pull/12181#discussion_r210331179
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -925,13 +925,23 @@ nightly_test_javascript() {
 nightly_model_backwards_compat_test() {
     set -ex
     export PYTHONPATH=/work/mxnet/python/
+
+    cd /work/venv
+    virtualenv -p python3
+    source /work/venv/bin/activate
 
 Review comment:
   Why do we want to go for a virtual env here ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services