You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/09/24 08:19:31 UTC
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/2515
[SPARK-3675][SQL] Allow starting a JDBC server on an existing context
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark jdbcExistingContext
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2515
----
commit 7866fad85ce89d38547ffed904ac9a3dbce1aed3
Author: Michael Armbrust <mi...@databricks.com>
Date: 2014-09-24T06:13:20Z
Allows starting a JDBC server on an existing context.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-56629604
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20744/consoleFull) for PR 2515 at commit [`7866fad`](https://github.com/apache/spark/commit/7866fad85ce89d38547ffed904ac9a3dbce1aed3).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-67221570
Temporary tables don't show up in `show tables` (we should fix this, feel free to open a JIRA). You should still be able to query it though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by chernetsov <gi...@git.apache.org>.
Github user chernetsov commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-67220789
@marmbrus Hi, Michael.
I am trying to make use of the commit you introduced (access my rdd exposed to sqlcontext via registerTempTable) but have problems with it:
- I cherry-picked the change to 1.1.0 release
- edited my spark app to call `HiveThriftServer2.startWithContext(sqlContext)` and added app thread wait() in the very end so that job does not finish
- launched my app via spark-submit on local master
- all the programmatical sql operations (like `sqlContext.sql("select * from ...").collect().foreach(println)`) work fine
- thift server starts as well
- but connecting via beeline shows that no tables are exposed to it
```
0: jdbc:hive2://localhost:10000> show tables;
+---------+
| result |
+---------+
+---------+
No rows selected (0.136 seconds)
```
Is there any other trick I should do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-57259777
Is this actually usable in this form? IIRC there are a bunch of e.g. command line arguments the JDBC server takes in order to initialize. What about having a form where you can also pass in an arguments array in addition to a context.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-56633079
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20744/consoleFull) for PR 2515 at commit [`7866fad`](https://github.com/apache/spark/commit/7866fad85ce89d38547ffed904ac9a3dbce1aed3).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by chernetsov <gi...@git.apache.org>.
Github user chernetsov commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-67229520
Thank you for quick answer, @marmbrus
Indeed I was able to query table.
Created the jira to fix `show tables`: https://issues.apache.org/jira/browse/SPARK-4865
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-56633081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20744/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-57043080
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3675][SQL] Allow starting a JDBC server...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2515#issuecomment-57260608
@pwendell yeah, sorry I probably should have labeled this WIP, but it does actually work in this form. You just can't configure things like the port to listen on. Unfortunately I think those are read from env vars and so can't be set at runtime anyway...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org