[GitHub] [doris] SteNicholas commented on a diff in pull request #19681: [Enhancement](catalog) paimon catalog

["SteNicholas (via GitHub)" <gi...@apache.org>]

SteNicholas commented on code in PR #19681:
URL: https://github.com/apache/doris/pull/19681#discussion_r1198775706


##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -203,7 +204,7 @@ struct TBrokerScanRangeParams {
 
     // If partition_ids is set, data that doesn't in this partition will be filtered.
     8: optional list<i64> partition_ids
-    

Review Comment:
   No necessary change in this line. Revert.



##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -232,7 +233,7 @@ struct TEsScanRange {
   1: required list<Types.TNetworkAddress> es_hosts  //  es hosts is used by be scan node to connect to es
   // has to set index and type here, could not set it in scannode
   // because on scan node maybe scan an es alias then it contains one or more indices
-  2: required string index   

Review Comment:
   No necessary change in this line. Revert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org