You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "smaheshwar-pltr (via GitHub)" <gi...@apache.org> on 2025/08/30 23:22:11 UTC
[PR] refactor: default equality operators for statistic file structs [iceberg-cpp]
smaheshwar-pltr opened a new pull request, #202:
URL: https://github.com/apache/iceberg-cpp/pull/202
Elsewhere in the project, equality operators are defaulted e.g.
https://github.com/apache/iceberg-cpp/blob/9f13bac62617e5b457be894e9f17eb89c78a0adb/src/iceberg/manifest_list.h#L196
I think for consistency, the `src/iceberg/statistics_file.h` equality operators can be defaulted too, as they do memberwise comparisons using each type's `operator==`.
(I'm new to this project, so please take with a pinch of salt 😄)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] refactor: default equality operators for statistic file structs [iceberg-cpp]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #202:
URL: https://github.com/apache/iceberg-cpp/pull/202#issuecomment-3243016363
Nice one @smaheshwar-pltr and thanks for the review @wgtmac and @zhjwpku
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] refactor: default equality operators for statistic file structs [iceberg-cpp]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #202:
URL: https://github.com/apache/iceberg-cpp/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org