You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2024/04/25 03:06:22 UTC
[PR] GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+. [arrow]
CurtHagenlocher opened a new pull request, #41374:
URL: https://github.com/apache/arrow/pull/41374
### What changes are included in this PR?
Adds code to avoid an allocation when converting from SqlDecimal to Decimal128.
Adds a .NET 8 target to Apache.Arrow.csproj (to enable the optimization) and to Apache.Arrow.Tests.csproj (to test the optimization).
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
Closes #41349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+. [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #41374:
URL: https://github.com/apache/arrow/pull/41374#issuecomment-2076283741
Waiting for #41376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+. [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #41374:
URL: https://github.com/apache/arrow/pull/41374#issuecomment-2076276147
Hmm... I guess I'll create a separate PR first to move the infrastructure to 8.0.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+. [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher closed pull request #41374: GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+.
URL: https://github.com/apache/arrow/pull/41374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+. [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41374:
URL: https://github.com/apache/arrow/pull/41374#issuecomment-2076268866
:warning: GitHub issue #41349 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41349: [C#] Optimize DecimalUtility.GetBytes(SqlDecimal) on .NET 7+. [arrow]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #41374:
URL: https://github.com/apache/arrow/pull/41374#issuecomment-2079408419
I suck at rebase. May need to withdraw and resubmit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org