[GitHub] [superset] geido commented on a change in pull request #17568: feat: Improved SQL Lab Grid rendering

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #17568:
URL: https://github.com/apache/superset/pull/17568#discussion_r758245648



##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -424,24 +424,21 @@ export default class FilterableTable extends PureComponent<
     rowIndex: number;
     style: React.CSSProperties;
   }) {
+    // if (rowIndex === 0) {
+    //   return (
+    //     <div key={key} style={style}>
+    //       header
+    //     </div>
+    //   );
+    // }
+

Review comment:
       ```suggestion
       // if (rowIndex === 0) {
       //   return (
       //     <div key={key} style={style}>
       //       header
       //     </div>
       //   );
       // }
   
   ```

##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -475,46 +467,25 @@ export default class FilterableTable extends PureComponent<
     const getColumnWidth = ({ index }: { index: number }) =>
       this.widthsForColumnsByKey[orderedColumnKeys[index]];
 
+    const { innerWidth: width, innerHeight } = window;
+    console.log('width', width);
+    console.log('length', innerHeight);

Review comment:
       ```suggestion
       console.log('width', width);
       console.log('length', innerHeight);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org