You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2010/02/04 04:14:27 UTC
[jira] Created: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
ComponentSupport.addFacet adds a panel when there is only one component as a child
----------------------------------------------------------------------------------
Key: MYFACES-2534
URL: https://issues.apache.org/jira/browse/MYFACES-2534
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.0-beta-2
Reporter: Leonardo Uribe
Assignee: Leonardo Uribe
Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830978#action_12830978 ]
Leonardo Uribe commented on MYFACES-2534:
-----------------------------------------
I don't believe ri is doing that, because if so, why t:tree2 works with tomahawk (it should throw the same error and in the real example it is not)? Instead, I think this is an error on the spec.
> ComponentSupport.addFacet adds a panel when there is only one component as a child
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2534
> URL: https://issues.apache.org/jira/browse/MYFACES-2534
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-2
>
>
> Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831454#action_12831454 ]
Jakob Korherr commented on MYFACES-2534:
----------------------------------------
OK good
> ComponentSupport.addFacet adds a panel when there is only one component as a child
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2534
> URL: https://issues.apache.org/jira/browse/MYFACES-2534
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-2
>
>
> Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830982#action_12830982 ]
Jakob Korherr commented on MYFACES-2534:
----------------------------------------
Good point. But when I implemented this for myfaces I tested this scenario with RI and they really created an UIPanel for one component. Maybe they changed this behavior...
Another undocumented change. Yippee!
> ComponentSupport.addFacet adds a panel when there is only one component as a child
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2534
> URL: https://issues.apache.org/jira/browse/MYFACES-2534
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-2
>
>
> Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831270#action_12831270 ]
Leonardo Uribe commented on MYFACES-2534:
-----------------------------------------
I think the comment there is referred to f:metadata behavior. We ensure that in ViewMetadataHandler, so it is ok.
> ComponentSupport.addFacet adds a panel when there is only one component as a child
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2534
> URL: https://issues.apache.org/jira/browse/MYFACES-2534
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-2
>
>
> Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2534.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-beta-2
> ComponentSupport.addFacet adds a panel when there is only one component as a child
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2534
> URL: https://issues.apache.org/jira/browse/MYFACES-2534
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-2
>
>
> Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr reopened MYFACES-2534:
------------------------------------
Leonardo,
As I told you earlier on MYFACES-2435, the spec says that every child of the facet has to be an UIPanel:
" [...] The implementation must ensure that the direct child of the facet is a UIPanel, even if there is only one child of the facet. [...]"
So please roll back the changes and change the tomahawk components instead!
> ComponentSupport.addFacet adds a panel when there is only one component as a child
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2534
> URL: https://issues.apache.org/jira/browse/MYFACES-2534
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-2
>
>
> Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2534) ComponentSupport.addFacet adds a
panel when there is only one component as a child
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr resolved MYFACES-2534.
------------------------------------
Resolution: Fixed
> ComponentSupport.addFacet adds a panel when there is only one component as a child
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2534
> URL: https://issues.apache.org/jira/browse/MYFACES-2534
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-2
>
>
> Old behavior must be preserved, otherwise some components like t:tree2 will not work correctly. This fix the other problem in TOMAHAWK-1486
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.