[GitHub] [logging-log4cxx] natale-p commented on issue #194: Compile log4cxx statically

["natale-p (via GitHub)" <gi...@apache.org>]

natale-p commented on issue #194:
URL: https://github.com/apache/logging-log4cxx/issues/194#issuecomment-1427591420

   I forgot to indicate that the problem is with log4cxx 0.13. I tried reproducing with the latest version, but it compiles correctly: no issue. So I suppose this issue can be closed, but for reference, it can be solved with the following:
   
   ```
   diff --git i/src/main/include/log4cxx/private/log4cxx_private.h.in w/src/main/include/log4cxx/private/log4cxx_private.h.in
   index 61e8e7ac..0e8dfb14 100644
   --- i/src/main/include/log4cxx/private/log4cxx_private.h.in
   +++ w/src/main/include/log4cxx/private/log4cxx_private.h.in
   @@ -26,7 +26,7 @@
   
    #include <log4cxx/log4cxx.h>
   
   -#if !defined(LOG4CXX) && !defined(LOG4CXX_TEST)
   +#if !defined(LOG4CXX) && !defined(LOG4CXX_TEST) && !defined(LOG4CXX_STATIC)
    #error "log4cxx/private/log4cxx_private.h should only be used within log4cxx implementation or tests"
    #endif
   
   ```
   
   (or with upgrading to 1.0.0)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org