You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2021/12/03 18:49:12 UTC

[ofbiz-framework] branch trunk updated: Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 086d4d4  Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
086d4d4 is described below

commit 086d4d4bfe71e2bac7386ea031ca782270ad0dc1
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Fri Dec 3 19:41:36 2021 +0100

    Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
    
    Adjusts the spotbugs/exclude.xml file to remove no super::clone reports
---
 spotbugs/exclude.xml | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/spotbugs/exclude.xml b/spotbugs/exclude.xml
index 349e3c3..532c2b2 100644
--- a/spotbugs/exclude.xml
+++ b/spotbugs/exclude.xml
@@ -3,22 +3,25 @@
               xmlns="https://github.com/spotbugs/filter/3.0.0"
               xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
-  <Match>
+              
+  <!-- CN_IDIOM_NO_SUPER_CALL = clone method does not call supper.clone(). OK since shallow clone wanted-->
+  <Match>  
     <Class name="org.apache.ofbiz.entity.GenericEntity" />
     <Method name="clone" />
     <Bug pattern="CN_IDIOM_NO_SUPER_CALL" />
-    <Priority value="2" />
+    <Confidence value="1" />
   </Match>
   <Match>
     <Class name="org.apache.ofbiz.entity.GenericPK" />
     <Method name="clone" />
     <Bug pattern="CN_IDIOM_NO_SUPER_CALL" />
-    <Priority value="2" />
+    <Confidence value="1" />
   </Match>
   <Match>
     <Class name="org.apache.ofbiz.entity.GenericValue" />
     <Method name="clone" />
     <Bug pattern="CN_IDIOM_NO_SUPER_CALL" />
-    <Priority value="2" />
+    <Confidence value="1" />
   </Match>
+  
 </FindBugsFilter>