You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/01/10 17:11:11 UTC
Review Request 55384: Handle cancelling of add/delete component by
user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55384/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-19447
https://issues.apache.org/jira/browse/AMBARI-19447
Repository: ambari
Description
-------
**STR**
1. Attempt to add/delete any host component that potentially requires configs changes.
2. Close confirmation popup before configs request is complete.
3. Repeat (1) for other component that potentially requires configs changes.
**Result**
Properties affected by the first component are displayed inside the confirmation popup for the second one.
Diffs
-----
ambari-web/app/controllers/main/host/details.js e2a2d8e
ambari-web/test/controllers/main/host/details_test.js f047f15
Diff: https://reviews.apache.org/r/55384/diff/
Testing
-------
20389 tests complete (33 seconds)
153 tests pending
Thanks,
Andriy Babiichuk
Re: Review Request 55384: Handle cancelling of add/delete component
by user
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55384/#review161081
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u042f\u043d\u0432. 10, 2017, 5:11 \u043f.\u043f., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55384/
> -----------------------------------------------------------
>
> (Updated \u042f\u043d\u0432. 10, 2017, 5:11 \u043f.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-19447
> https://issues.apache.org/jira/browse/AMBARI-19447
>
>
> Repository: ambari
>
>
> Description
> -------
>
> **STR**
> 1. Attempt to add/delete any host component that potentially requires configs changes.
> 2. Close confirmation popup before configs request is complete.
> 3. Repeat (1) for other component that potentially requires configs changes.
>
> **Result**
> Properties affected by the first component are displayed inside the confirmation popup for the second one.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host/details.js e2a2d8e
> ambari-web/test/controllers/main/host/details_test.js f047f15
>
> Diff: https://reviews.apache.org/r/55384/diff/
>
>
> Testing
> -------
>
> 20389 tests complete (33 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>