You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/29 08:20:37 UTC
[GitHub] [airflow] mik-laj commented on pull request #12558: Add connection form support to provider discovery
mik-laj commented on pull request #12558:
URL: https://github.com/apache/airflow/pull/12558#issuecomment-735359901
Unfortunately, the form does not work for me.
```
Traceback (most recent call last):
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 2464, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 2450, in wsgi_app
response = self.handle_exception(e)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 1867, in handle_exception
reraise(exc_type, exc_value, tb)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 2447, in wsgi_app
response = self.full_dispatch_request()
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 1952, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 1821, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
raise value
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 1950, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/app.py", line 1936, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/security/decorators.py", line 109, in wraps
return f(self, *args, **kwargs)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/views.py", line 610, in edit
related_views=self._related_views,
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/baseviews.py", line 281, in render_template
template, **dict(list(kwargs.items()) + list(self.extra_args.items()))
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/templating.py", line 140, in render_template
ctx.app,
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask/templating.py", line 120, in _render
rv = template.render(context)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/jinja2/environment.py", line 1090, in render
self.environment.handle_exception()
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/jinja2/environment.py", line 832, in handle_exception
reraise(*rewrite_traceback_stack(source=source))
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/jinja2/_compat.py", line 28, in reraise
raise value.with_traceback(tb)
File "/Users/kamilbregula/devel/google-airflow/airflow/airflow/www/templates/airflow/conn_edit.html", line 20, in top-level template code
{% extends 'appbuilder/general/model/edit.html' %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/model/edit.html", line 2, in top-level template code
{% import 'appbuilder/general/lib.html' as lib %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/base.html", line 1, in top-level template code
{% extends base_template %}
File "/Users/kamilbregula/devel/google-airflow/airflow/airflow/www/templates/airflow/main.html", line 20, in top-level template code
{% extends 'appbuilder/baselayout.html' %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/baselayout.html", line 2, in top-level template code
{% import 'appbuilder/baselib.html' as baselib %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/init.html", line 46, in top-level template code
{% block body %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/baselayout.html", line 19, in block "body"
{% block content %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/model/edit.html", line 23, in block "content"
{% block edit_form %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/model/edit.html", line 25, in block "edit_form"
{{ widgets.get('edit')(form_action=form_action)|safe }}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/widgets.py", line 37, in __call__
return template.render(args)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/jinja2/environment.py", line 1090, in render
self.environment.handle_exception()
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/jinja2/environment.py", line 832, in handle_exception
reraise(*rewrite_traceback_stack(source=source))
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/jinja2/_compat.py", line 28, in reraise
raise value.with_traceback(tb)
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/flask_appbuilder/templates/appbuilder/general/widgets/form.html", line 43, in top-level template code
{% if field.name not in exclude_cols %}
File "/Users/kamilbregula/.virtualenvs/airflow/lib/python3.6/site-packages/jinja2/environment.py", line 471, in getattr
return getattr(obj, attribute)
jinja2.exceptions.UndefinedError: 'airflow.www.forms.ConnectionForm object' has no attribute 'extra__jdbc__drv_path'
```
It looks like a little more code needs to be updated.
https://github.com/apache/airflow/blob/master/airflow/www/views.py#L2829-L2848
https://github.com/apache/airflow/blob/7ef9aa7d545f11442b6ebb86590cd8ce5f98430b/airflow/www/views.py#L2890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org