You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jatin9896 <gi...@git.apache.org> on 2017/07/05 12:08:59 UTC
[GitHub] carbondata pull request #1137: [CARBONDATA-1266] Fixed issue for non existin...
GitHub user jatin9896 opened a pull request:
https://github.com/apache/carbondata/pull/1137
[CARBONDATA-1266] Fixed issue for non existing table
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jatin9896/incubator-carbondata CARBONDATA-1266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1137
----
commit b7844b967e05558b2f6f3a65fc7683aa98521939
Author: jatin <ja...@knoldus.in>
Date: 2017-07-05T12:04:19Z
Fixed issue for non existing table
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1137
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2926/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1137: [CARBONDATA-1266] Fixed issue for non existin...
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1137#discussion_r125872632
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataMetadata.java ---
@@ -115,9 +115,6 @@ private ConnectorTableMetadata getTableMetadata(SchemaTableName schemaTableName)
}
CarbonTable carbonTable = carbonTableReader.getTable(schemaTableName);
--- End diff --
Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1137
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/325/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1137
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2911/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1137
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2933/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1137
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/347/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/1137
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by jatin9896 <gi...@git.apache.org>.
Github user jatin9896 commented on the issue:
https://github.com/apache/carbondata/pull/1137
@jackylk I did the required changes. Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1137
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/340/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1137: [CARBONDATA-1266] Fixed issue for non existin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1137: [CARBONDATA-1266] Fixed issue for non existin...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1137#discussion_r125685468
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java ---
@@ -251,7 +251,7 @@ private CarbonTable loadTableMetadata(SchemaTableName schemaTableName) {
return parseCarbonMetadata(table);
}
- return null;
+ throw new RuntimeException("Table Doesn't Exist");
--- End diff --
should use `TableNotFoundException`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1137: [CARBONDATA-1266] Fixed issue for non existin...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1137#discussion_r125866018
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataMetadata.java ---
@@ -115,9 +115,6 @@ private ConnectorTableMetadata getTableMetadata(SchemaTableName schemaTableName)
}
CarbonTable carbonTable = carbonTableReader.getTable(schemaTableName);
--- End diff --
I found there is one more place, how about line 150?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1137: [CARBONDATA-1266] Fixed issue for non existing table
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1137
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1137: [CARBONDATA-1266] Fixed issue for non existin...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1137#discussion_r125685584
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java ---
@@ -251,7 +251,7 @@ private CarbonTable loadTableMetadata(SchemaTableName schemaTableName) {
return parseCarbonMetadata(table);
}
- return null;
+ throw new RuntimeException("Table Doesn't Exist");
--- End diff --
And remove the null check in caller
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---