You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/30 05:20:26 UTC

[GitHub] [pulsar] addisonj opened a new pull request #14056: Add a default timeout for OAuth2 Metadata Resolver

addisonj opened a new pull request #14056:
URL: https://github.com/apache/pulsar/pull/14056


   Currently, there is no timeout on the metadata resolver in oauth2
   clients.
   
   This can result in a connection hanging indefintely.
   
   We should add sane defaults here.
   
   These defaults match the defaults of the TokenClient and generally the
   Pulsar defaults of 10s connect timeout and 30s read timeout
   
   ## Test
   
   This seems to primarily depend on testing timeout of the java HTTP lib, so no test is likely needed.
   
   ## Doc
   
   This is a trivial change and doesn't require docs
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14056: Add a default timeout for OAuth2 Metadata Resolver

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14056:
URL: https://github.com/apache/pulsar/pull/14056#issuecomment-1025073038


   @addisonj:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 merged pull request #14056: Add a default timeout for OAuth2 Metadata Resolver

Posted by GitBox <gi...@apache.org>.
hangc0276 merged pull request #14056:
URL: https://github.com/apache/pulsar/pull/14056


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org