You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "rulle-io (via GitHub)" <gi...@apache.org> on 2023/03/03 22:01:10 UTC
[GitHub] [avro] rulle-io opened a new pull request, #2121: avro-tools: Add log entry when an external schema is used
rulle-io opened a new pull request, #2121:
URL: https://github.com/apache/avro/pull/2121
## What is the purpose of the change
When `avro-tools fromjson` parameter `--schema-file` or `--schema` is used, it is unclear whether the tool actually picked up the provided schema.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Also a couple of code style warnings are fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] rulle-io commented on pull request #2121: AVRO-3845: avro-tools: Add log entry when an external schema is used
Posted by "rulle-io (via GitHub)" <gi...@apache.org>.
rulle-io commented on PR #2121:
URL: https://github.com/apache/avro/pull/2121#issuecomment-1694263659
Done: https://issues.apache.org/jira/browse/AVRO-3845 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2121: avro-tools: Add log entry when an external schema is used
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2121:
URL: https://github.com/apache/avro/pull/2121#issuecomment-1594182964
Nice small change.
Please, could you create a JIRA (as explain on [how to contribute](https://avro.apache.org/project/how-to-contribute/#making-changes)), then i'll approve the change and then ping a commiter about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] rulle-io commented on pull request #2121: AVRO-3845: avro-tools: Add log entry when an external schema is used
Posted by "rulle-io (via GitHub)" <gi...@apache.org>.
rulle-io commented on PR #2121:
URL: https://github.com/apache/avro/pull/2121#issuecomment-1694338796
Tested manully:
### --schema-file
```
avro-tools fromjson --schema-file example.avro example.json
...
23/08/26 14:46:15 INFO tool.DataFileReadTool: Reading schema from file 'example.avro'
```
### --schema
```
avro-tools fromjson --schema {"namespace":"example.avro","type":"record","name":"User","fields":[{"name":"name","type":"string"},{"name":"favorite_number","type":"int"},{"name":"favorite_color","type":"string"}]} example.avro
...
23/08/26 15:04:33 INFO tool.DataFileReadTool: Reading schema from string '{namespace:example.avro,type:record,name:User,fields:[{name:name,type:string},{name:favorite_number,type:int},{name:favorite_color,type:string}]}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] rulle-io commented on pull request #2121: avro-tools: Add log entry when an external schema is used
Posted by "rulle-io (via GitHub)" <gi...@apache.org>.
rulle-io commented on PR #2121:
URL: https://github.com/apache/avro/pull/2121#issuecomment-1690502195
Thanks @clesaec. I have sent a request to get a Jira user (to create a ticket). But no response since a few weeks back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #2121: avro-tools: Add log entry when an external schema is used
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2121:
URL: https://github.com/apache/avro/pull/2121#issuecomment-1690593059
@rulle-io
```
ASF Self-serve Portal - Friday, July 14, 2023 8:55:26 AM GMT+3
New Jira account created: rulle-io
Hi there,
As approved by mgrigorov@apache.org, a new Jira user account, rulle-io, has been created.
They provided the public name: Ruslan Altynnikov
and the reason: Submit a PR
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk merged pull request #2121: AVRO-3845: avro-tools: Add log entry when an external schema is used
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk merged PR #2121:
URL: https://github.com/apache/avro/pull/2121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org