You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/20 05:38:22 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10275: [Broker] Suppress printing of "skip Processing" lines in startup scripts

lhotari opened a new pull request #10275:
URL: https://github.com/apache/pulsar/pull/10275


   ### Motivation
   
   The startup logging of the broker (and bookie) is very verbose after the changes made in #8709 .
   
   example of typical output:
   ```
   [conf/broker.conf] skip Processing #
   [conf/broker.conf] skip Processing # Licensed to the Apache Software Foundation (ASF) under one
   [conf/broker.conf] skip Processing # or more contributor license agreements.  See the NOTICE file
   [conf/broker.conf] skip Processing # distributed with this work for additional information
   [conf/broker.conf] skip Processing # regarding copyright ownership.  The ASF licenses this file
   [conf/broker.conf] skip Processing # to you under the Apache License, Version 2.0 (the
   [conf/broker.conf] skip Processing # "License"); you may not use this file except in compliance
   [conf/broker.conf] skip Processing # with the License.  You may obtain a copy of the License at
   [conf/broker.conf] skip Processing #
   [conf/broker.conf] skip Processing #   http://www.apache.org/licenses/LICENSE-2.0
   [conf/broker.conf] skip Processing #
   [conf/broker.conf] skip Processing # Unless required by applicable law or agreed to in writing,
   [conf/broker.conf] skip Processing # software distributed under the License is distributed on an
   [conf/broker.conf] skip Processing # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   [conf/broker.conf] skip Processing # KIND, either express or implied.  See the License for the
   [conf/broker.conf] skip Processing # specific language governing permissions and limitations
   [conf/broker.conf] skip Processing # under the License.
   [conf/broker.conf] skip Processing #
   [conf/broker.conf] skip Processing ### --- General broker settings --- ###
   [conf/broker.conf] skip Processing # Zookeeper quorum connection string
   [conf/broker.conf] skip Processing # Configuration Store connection string
   [conf/broker.conf] skip Processing # Broker data port
   [conf/broker.conf] skip Processing # Broker data port for TLS - By default TLS is disabled
   [conf/broker.conf] skip Processing # Port to use to server HTTP request
   [conf/broker.conf] skip Processing # Port to use to server HTTPS request - By default TLS is disabled
   [conf/broker.conf] skip Processing # Hostname or IP address the service binds on, default is 0.0.0.0.
   ```
   
   ### Modifications
   
   Suppress printing the `skip Processing` lines unless `PF_ENV_DEBUG` environment variable is set to `1`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie merged pull request #10275: [Broker] Suppress printing of "skip Processing" lines in startup scripts

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #10275:
URL: https://github.com/apache/pulsar/pull/10275


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lhotari commented on pull request #10275: [Broker] Suppress printing of "skip Processing" lines in startup scripts

Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10275:
URL: https://github.com/apache/pulsar/pull/10275#issuecomment-822988622


   @klwilson227 @codelipenghui Please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org