[GitHub] [maven-resolver] caiwei-ebay commented on a change in pull request #137: [MRESOLVER-228] Proposed changes

[GitBox <gi...@apache.org>]

caiwei-ebay commented on a change in pull request #137:
URL: https://github.com/apache/maven-resolver/pull/137#discussion_r758174653



##########
File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##########
@@ -169,8 +161,13 @@ public CollectResult collectDependencies( RepositorySystemSession session, Colle
         requireNonNull( request, "request cannot be null" );
         session = optimizeSession( session );
 
-        verbose = ConfigUtils.getBoolean( session, false, CONFIG_PROP_RESOLVER_VERBOSE_MODE );
-        skipMode = ConfigUtils.getBoolean( session, true, CONFIG_PROP_RESOLVER_MODE );
+        boolean useSkipReconcile = ConfigUtils.getBoolean(
+                session, CONFIG_PROP_USE_SKIP_RECONCILE_DEFAULT, CONFIG_PROP_USE_SKIP_RECONCILE
+        );
+        if ( useSkipReconcile )
+        {
+            LOGGER.debug( "Collector skip & reconcile enabled." );

Review comment:
       @michael-o @cstamas 
   
   Thanks for reviewing and updating the PR.
    
   I provide a property just for compatibility consideration. As I'm confident with the "skip & reconcile" approach as we've dryrun 2000+ applications in our company, so I would raise both hands in favour of that we don't provide a property to disable this behavior.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org