You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Alex Harui <ah...@adobe.com.INVALID> on 2019/04/18 03:35:02 UTC
Re: [royale-asjs] branch develop updated: core-HTMLElementWrapper:
make getActualDispatcher_ function use positioner instead element
This caught my eye. Are we sure about this? If I create a Button by wrapping a <button> in a <div> I would think many events want to come directly from the button and not the div, but I can certainly understand the opposite could be true as well. What was the scenario here?
-Alex
On 4/17/19, 2:55 PM, "carlosrovira@apache.org" <ca...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C3c916dc5dfa2462e3c7108d6c37f5a86%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636911349076776345&sdata=k08fa1pwB9jQ7jwx1z0190OBt5CVnb6yHchQ73oA%2Fz0%3D&reserved=0
The following commit(s) were added to refs/heads/develop by this push:
new e458f7c core-HTMLElementWrapper: make getActualDispatcher_ function use positioner instead element
e458f7c is described below
commit e458f7c083cff64032d6081b4676454af46b5457
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Wed Apr 17 23:54:55 2019 +0200
core-HTMLElementWrapper: make getActualDispatcher_ function use positioner instead element
---
.../Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as
index 4ebff5a..54a2d6c 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as
@@ -261,7 +261,7 @@ package org.apache.royale.core
var source:Object = this;
if (ElementEvents.elementEvents[type]) {
// mouse and keyboard events also dispatch off the element.
- source = this.element;
+ source = this.positioner;
}
return source;
}
Re: [royale-asjs] branch develop updated: core-HTMLElementWrapper:
make getActualDispatcher_ function use positioner instead element
Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
You're right, and for this reason I reverted just few minutes. Sure you
already saw that :).
In fact the change failed since positioner is in UIBase not in that
class.Don't know how compilation succeed when I tested before commit.
Anyway, the real change I needed was in ItemRendererMouseController since
it really needs to be "positioner" instead "element". This happens in
TabBar where renderers have Content and is not filling all bounding box.
That case make mouse only works inside the content and not in the zone
outside element but inside positioner.
El jue., 18 abr. 2019 a las 5:35, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> This caught my eye. Are we sure about this? If I create a Button by
> wrapping a <button> in a <div> I would think many events want to come
> directly from the button and not the div, but I can certainly understand
> the opposite could be true as well. What was the scenario here?
>
> -Alex
>
> On 4/17/19, 2:55 PM, "carlosrovira@apache.org" <ca...@apache.org>
> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> carlosrovira pushed a commit to branch develop
> in repository
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7C3c916dc5dfa2462e3c7108d6c37f5a86%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636911349076776345&sdata=k08fa1pwB9jQ7jwx1z0190OBt5CVnb6yHchQ73oA%2Fz0%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new e458f7c core-HTMLElementWrapper: make getActualDispatcher_
> function use positioner instead element
> e458f7c is described below
>
> commit e458f7c083cff64032d6081b4676454af46b5457
> Author: Carlos Rovira <ca...@apache.org>
> AuthorDate: Wed Apr 17 23:54:55 2019 +0200
>
> core-HTMLElementWrapper: make getActualDispatcher_ function use
> positioner instead element
> ---
>
> .../Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as |
> 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as
> b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as
> index 4ebff5a..54a2d6c 100644
> ---
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as
> +++
> b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/HTMLElementWrapper.as
> @@ -261,7 +261,7 @@ package org.apache.royale.core
> var source:Object = this;
> if (ElementEvents.elementEvents[type]) {
> // mouse and keyboard events also dispatch off the
> element.
> - source = this.element;
> + source = this.positioner;
> }
> return source;
> }
>
>
>
>
--
Carlos Rovira
http://about.me/carlosrovira