You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/15 12:09:56 UTC
[GitHub] [hbase] HorizonNet opened a new pull request #1046: HBASE-23623
Reduced the number of Checkstyle violations in hbase-rest
HorizonNet opened a new pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046
Backport of #970 to branch-1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1046: HBASE-23623 Reduced
the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#issuecomment-575081750
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 47s | branch-1 passed |
| +1 :green_heart: | compile | 0m 19s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 0m 26s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 0m 36s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 53s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 28s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 26s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 1m 15s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 11s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 55s | the patch passed |
| +1 :green_heart: | compile | 0m 21s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javac | 0m 21s | the patch passed |
| +1 :green_heart: | compile | 0m 26s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | javac | 0m 26s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 30s | hbase-rest: The patch generated 0 new + 21 unchanged - 49 fixed = 21 total (was 70) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 19s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | findbugs | 1m 12s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 14m 5s | hbase-rest in the patch passed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 54m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1046 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 760cad888e64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh |
| git revision | branch-1 / 99a328f |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/testReport/ |
| Max. process+thread count | 2031 (vs. ulimit of 10000) |
| modules | C: hbase-rest U: hbase-rest |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367307938
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366964628
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesResource.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be using `/*` instead of `/**`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367308022
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366965522
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be using /* instead of /**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367307915
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteHTableRetries.java
##########
@@ -1,4 +1,4 @@
-/*
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367307987
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367307767
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366965921
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be using /* instead of /**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367307810
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesResource.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366964034
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be doing `/*` instead of `/**`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1046: HBASE-23623 Reduced
the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#issuecomment-574651770
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 22s | branch-1 passed |
| +1 :green_heart: | compile | 0m 21s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 0m 26s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 0m 37s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 55s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 29s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 25s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 1m 14s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 12s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 55s | the patch passed |
| +1 :green_heart: | compile | 0m 20s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 0m 20s | the patch passed |
| +1 :green_heart: | compile | 0m 26s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 0m 26s | the patch passed |
| -1 :x: | checkstyle | 0m 31s | hbase-rest: The patch generated 1 new + 22 unchanged - 48 fixed = 23 total (was 70) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 51s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 19s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 0m 27s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | findbugs | 1m 13s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 14m 31s | hbase-rest in the patch passed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 46m 38s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1046 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b6b617a3b334 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh |
| git revision | branch-1 / 907184d |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/artifact/out/diff-checkstyle-hbase-rest.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/testReport/ |
| Max. process+thread count | 2058 (vs. ulimit of 10000) |
| modules | C: hbase-rest U: hbase-rest |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366965354
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteHTableRetries.java
##########
@@ -1,4 +1,4 @@
-/*
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be using /* instead of /**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366965830
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be using /* instead of /**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367307844
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithLabels.java
##########
@@ -1,4 +1,4 @@
-/*
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366964914
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be using /* instead of /**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1046: HBASE-23623 Reduced
the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#issuecomment-574805181
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 46s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| -1 :x: | mvninstall | 0m 9s | root in branch-1 failed. |
| -1 :x: | compile | 0m 7s | hbase-rest in branch-1 failed with JDK v1.8.0_232. |
| -1 :x: | compile | 0m 6s | hbase-rest in branch-1 failed with JDK v1.7.0_242. |
| -1 :x: | checkstyle | 0m 5s | The patch fails to run checkstyle in hbase-rest |
| -1 :x: | shadedjars | 0m 6s | branch has 11 errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 6s | hbase-rest in branch-1 failed with JDK v1.8.0_232. |
| -1 :x: | javadoc | 0m 8s | hbase-rest in branch-1 failed with JDK v1.7.0_242. |
| +0 :ok: | spotbugs | 0m 27s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| -1 :x: | findbugs | 0m 7s | hbase-rest in branch-1 failed. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 7s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | hbase-rest in the patch failed with JDK v1.8.0_232. |
| -1 :x: | javac | 0m 6s | hbase-rest in the patch failed with JDK v1.8.0_232. |
| -1 :x: | compile | 0m 7s | hbase-rest in the patch failed with JDK v1.7.0_242. |
| -1 :x: | javac | 0m 7s | hbase-rest in the patch failed with JDK v1.7.0_242. |
| -1 :x: | checkstyle | 0m 5s | The patch fails to run checkstyle in hbase-rest |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 0m 5s | patch has 11 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 0m 6s | The patch causes 11 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 0m 11s | The patch causes 11 errors with Hadoop v2.9.2. |
| -1 :x: | javadoc | 0m 6s | hbase-rest in the patch failed with JDK v1.8.0_232. |
| -1 :x: | javadoc | 0m 7s | hbase-rest in the patch failed with JDK v1.7.0_242. |
| -1 :x: | findbugs | 0m 8s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 7s | hbase-rest in the patch failed. |
| +0 :ok: | asflicense | 0m 7s | ASF License check generated no output? |
| | | 4m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1046 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 993b0752a80e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh |
| git revision | branch-1 / 907184d |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-compile-hbase-rest-jdk1.8.0_232.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-compile-hbase-rest-jdk1.7.0_242.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/maven-branch-checkstyle-hbase-rest.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-shadedjars.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-javadoc-hbase-rest-jdk1.8.0_232.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-javadoc-hbase-rest-jdk1.7.0_242.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/branch-findbugs-hbase-rest.txt |
| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.8.0_232.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.8.0_232.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.7.0_242.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-compile-hbase-rest-jdk1.7.0_242.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/maven-patch-checkstyle-hbase-rest.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javac-2.9.2.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javadoc-hbase-rest-jdk1.8.0_232.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-javadoc-hbase-rest-jdk1.7.0_242.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-findbugs-hbase-rest.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/artifact/out/patch-unit-hbase-rest.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/testReport/ |
| Max. process+thread count | 46 (vs. ulimit of 10000) |
| modules | C: hbase-rest U: hbase-rest |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/2/console |
| versions | git=1.9.1 maven=3.0.5 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r366964823
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithLabels.java
##########
@@ -1,4 +1,4 @@
-/*
+/**
Review comment:
this is a file header and not a javadoc. shouldn't we be using /* instead of /**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1046: HBASE-23623 Reduced
the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#issuecomment-576452737
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 43s | branch-1 passed |
| +1 :green_heart: | compile | 0m 22s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 0m 27s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 0m 37s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 30s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 29s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 1m 17s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 15s | branch-1 passed |
| -0 :warning: | patch | 1m 25s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 2s | the patch passed |
| +1 :green_heart: | compile | 0m 23s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javac | 0m 23s | the patch passed |
| +1 :green_heart: | compile | 0m 28s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | javac | 0m 28s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | hbase-rest: The patch generated 0 new + 18 unchanged - 33 fixed = 18 total (was 51) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 59s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 12s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | findbugs | 1m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 14m 47s | hbase-rest in the patch passed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 48m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1046 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 617896b749df 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1046/out/precommit/personality/provided.sh |
| git revision | branch-1 / 2e3273f |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/testReport/ |
| Max. process+thread count | 2014 (vs. ulimit of 10000) |
| modules | C: hbase-rest U: hbase-rest |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1046/4/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1046:
HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046#discussion_r367307878
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
##########
@@ -1,5 +1,4 @@
-/*
- *
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #1046: HBASE-23623 Reduced
the number of Checkstyle violations in hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet merged pull request #1046: HBASE-23623 Reduced the number of Checkstyle violations in hbase-rest
URL: https://github.com/apache/hbase/pull/1046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services