[GitHub] [pulsar-client-go] merlimat opened a new pull request #521: Always check connection close channell, before attempting to put requests

[GitBox <gi...@apache.org>]

merlimat opened a new pull request #521:
URL: https://github.com/apache/pulsar-client-go/pull/521


   Fixes #520
   
   ### Motivation
   
   The panic is triggered because the `Connection.incomingRequestsCh` is already closed in the moment we're trying to do something with that connection.
   
   In order to avoid the race condition, we need to always check if `closeCh` is already closed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat commented on pull request #521: Always check connection close channell, before attempting to put requests

[GitBox <gi...@apache.org>]

merlimat commented on pull request #521:
URL: https://github.com/apache/pulsar-client-go/pull/521#issuecomment-845287775


   Yes, it's not feasible to reproduce in a unit tests or to assert that the issue is fixed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat merged pull request #521: Always check connection close channell, before attempting to put requests

[GitBox <gi...@apache.org>]

merlimat merged pull request #521:
URL: https://github.com/apache/pulsar-client-go/pull/521


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org