You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by sebb <se...@gmail.com> on 2013/02/13 13:10:13 UTC
Re: svn commit: r1445521 - /httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java
On 13 February 2013 09:51, <fx...@apache.org> wrote:
> Author: fx
> Date: Wed Feb 13 09:51:24 2013
> New Revision: 1445521
>
> URL: http://svn.apache.org/r1445521
> Log:
> HTTPCLIENT-1323: CachingHttpClient ignores params set on the request
>
> Modified:
> httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java
>
> Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java?rev=1445521&r1=1445520&r2=1445521&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java (original)
> +++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java Wed Feb 13 09:51:24 2013
> @@ -38,6 +38,7 @@ import org.apache.http.RequestLine;
> import org.apache.http.annotation.NotThreadSafe;
> import org.apache.http.message.AbstractHttpMessage;
> import org.apache.http.message.BasicRequestLine;
> +import org.apache.http.params.HttpParams;
> import org.apache.http.protocol.HTTP;
>
> /**
> @@ -141,4 +142,13 @@ public class HttpRequestWrapper extends
> }
> }
Please add Javadoc, including @deprecated tag with explanation as to
what to use instead.
> + @Override
> + @Deprecated
> + public HttpParams getParams() {
> + if (this.params == null) {
> + this.params = original.getParams().copy();
> + }
> + return this.params;
> + }
> +
> }
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Eclipse formatter/cleanup settings I use; was Re: svn commit: r1445521
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Feb 14, 2013 at 10:39 AM, Oleg Kalnichevski <ol...@apache.org>wrote:
> On Thu, 2013-02-14 at 10:04 -0500, Gary Gregory wrote:
> > On Thu, Feb 14, 2013 at 9:55 AM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
> >
> > > On Wed, 2013-02-13 at 14:52 +0100, François-Xavier Bonnet wrote:
> > > > I added javadoc for the deprecation.
> > > >
> > > > Does someone use Eclipse and has a proper configuration for code
> style,
> > > > javadoc warnings and code formatter? Importing all these settings
> would
> > > > help me.
> > >
> > > François-Xavier,
> > >
> > > Please find formatter and cleanup settings I use with my Eclipse
> > > attached to this message.
> > >
> > > What might be useful is for all of use to agree on some basic code
> > > formatting guidelines mandatory for all contributions (there is already
> > > a page for that in Wiki [1], albeit still unfinished), provide Eclipse
> > > (IntelliJ, etc) templates and enforce those guidelines through the
> > > style-check plugin.
> > >
> >
> > Why not save your eclipse settings under something like
> > ide/eclipse/<version>/ ?
> >
> > Then those of us on Eclipse can copy the file to the right place.
> >
> > Gary
> >
>
> This is a good idea. We should still agree on common guidelines first,
> though, in my opinion. Another important aspect is actually being able
> to enforce those guidelines through the style-check plugin (or similar
> compile time mechanism). This is likely to require a great deal of work
> which I presently cannot commit myself to.
>
Hm... maybe a first step would be to store your prefs in SVN and worry
about checkstyle later. At least if it is in SVN, some one else can pick up
the task if they feel so inclined.
Gary
>
> Oleg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Eclipse formatter/cleanup settings I use; was Re: svn commit:
r1445521
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Thu, 2013-02-14 at 10:04 -0500, Gary Gregory wrote:
> On Thu, Feb 14, 2013 at 9:55 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
>
> > On Wed, 2013-02-13 at 14:52 +0100, François-Xavier Bonnet wrote:
> > > I added javadoc for the deprecation.
> > >
> > > Does someone use Eclipse and has a proper configuration for code style,
> > > javadoc warnings and code formatter? Importing all these settings would
> > > help me.
> >
> > François-Xavier,
> >
> > Please find formatter and cleanup settings I use with my Eclipse
> > attached to this message.
> >
> > What might be useful is for all of use to agree on some basic code
> > formatting guidelines mandatory for all contributions (there is already
> > a page for that in Wiki [1], albeit still unfinished), provide Eclipse
> > (IntelliJ, etc) templates and enforce those guidelines through the
> > style-check plugin.
> >
>
> Why not save your eclipse settings under something like
> ide/eclipse/<version>/ ?
>
> Then those of us on Eclipse can copy the file to the right place.
>
> Gary
>
This is a good idea. We should still agree on common guidelines first,
though, in my opinion. Another important aspect is actually being able
to enforce those guidelines through the style-check plugin (or similar
compile time mechanism). This is likely to require a great deal of work
which I presently cannot commit myself to.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Eclipse formatter/cleanup settings I use; was Re: svn commit: r1445521
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Feb 14, 2013 at 9:55 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Wed, 2013-02-13 at 14:52 +0100, François-Xavier Bonnet wrote:
> > I added javadoc for the deprecation.
> >
> > Does someone use Eclipse and has a proper configuration for code style,
> > javadoc warnings and code formatter? Importing all these settings would
> > help me.
>
> François-Xavier,
>
> Please find formatter and cleanup settings I use with my Eclipse
> attached to this message.
>
> What might be useful is for all of use to agree on some basic code
> formatting guidelines mandatory for all contributions (there is already
> a page for that in Wiki [1], albeit still unfinished), provide Eclipse
> (IntelliJ, etc) templates and enforce those guidelines through the
> style-check plugin.
>
Why not save your eclipse settings under something like
ide/eclipse/<version>/ ?
Then those of us on Eclipse can copy the file to the right place.
Gary
>
> Oleg
>
> [1] http://wiki.apache.org/HttpComponents/CodingConventions
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Eclipse formatter/cleanup settings I use; was Re: svn commit:
r1445521
Posted by François-Xavier Bonnet <fr...@centraliens.net>.
Thanks Oleg, I am going to try with these settings.
On 14/02/2013 15:55, olegk@apache.org wrote:
> On Wed, 2013-02-13 at 14:52 +0100, François-Xavier Bonnet wrote:
>> I added javadoc for the deprecation.
>>
>> Does someone use Eclipse and has a proper configuration for code style,
>> javadoc warnings and code formatter? Importing all these settings would
>> help me.
> François-Xavier,
>
> Please find formatter and cleanup settings I use with my Eclipse
> attached to this message.
>
> What might be useful is for all of use to agree on some basic code
> formatting guidelines mandatory for all contributions (there is already
> a page for that in Wiki [1], albeit still unfinished), provide Eclipse
> (IntelliJ, etc) templates and enforce those guidelines through the
> style-check plugin.
>
> Oleg
>
> [1] http://wiki.apache.org/HttpComponents/CodingConventions
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Eclipse formatter/cleanup settings I use; was Re: svn commit:
r1445521
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Wed, 2013-02-13 at 14:52 +0100, François-Xavier Bonnet wrote:
> I added javadoc for the deprecation.
>
> Does someone use Eclipse and has a proper configuration for code style,
> javadoc warnings and code formatter? Importing all these settings would
> help me.
François-Xavier,
Please find formatter and cleanup settings I use with my Eclipse
attached to this message.
What might be useful is for all of use to agree on some basic code
formatting guidelines mandatory for all contributions (there is already
a page for that in Wiki [1], albeit still unfinished), provide Eclipse
(IntelliJ, etc) templates and enforce those guidelines through the
style-check plugin.
Oleg
[1] http://wiki.apache.org/HttpComponents/CodingConventions
Re: svn commit: r1445521 - /httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java
Posted by François-Xavier Bonnet <fr...@centraliens.net>.
I added javadoc for the deprecation.
Does someone use Eclipse and has a proper configuration for code style,
javadoc warnings and code formatter? Importing all these settings would
help me.
On 13/02/2013 13:10, sebb wrote:
> On 13 February 2013 09:51, <fx...@apache.org> wrote:
>> Author: fx
>> Date: Wed Feb 13 09:51:24 2013
>> New Revision: 1445521
>>
>> URL: http://svn.apache.org/r1445521
>> Log:
>> HTTPCLIENT-1323: CachingHttpClient ignores params set on the request
>>
>> Modified:
>> httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java
>>
>> Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java
>> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java?rev=1445521&r1=1445520&r2=1445521&view=diff
>> ==============================================================================
>> --- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java (original)
>> +++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/methods/HttpRequestWrapper.java Wed Feb 13 09:51:24 2013
>> @@ -38,6 +38,7 @@ import org.apache.http.RequestLine;
>> import org.apache.http.annotation.NotThreadSafe;
>> import org.apache.http.message.AbstractHttpMessage;
>> import org.apache.http.message.BasicRequestLine;
>> +import org.apache.http.params.HttpParams;
>> import org.apache.http.protocol.HTTP;
>>
>> /**
>> @@ -141,4 +142,13 @@ public class HttpRequestWrapper extends
>> }
>> }
> Please add Javadoc, including @deprecated tag with explanation as to
> what to use instead.
>
>> + @Override
>> + @Deprecated
>> + public HttpParams getParams() {
>> + if (this.params == null) {
>> + this.params = original.getParams().copy();
>> + }
>> + return this.params;
>> + }
>> +
>> }
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org