You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/11/17 15:34:06 UTC

Review Request 40389: Deleted properties appear in Add Service Wizard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40389/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Vitalyi Brodetskyi.


Bugs: AMBARI-13922
    https://issues.apache.org/jira/browse/AMBARI-13922


Repository: ambari


Description
-------

STR 1
1. Install cluster (Ambari 2.1.3) with HDFS
2. Enable HA (property dfs.namenode.rpc-address is deleted)
3. Run Add Service Wizard, select add storm

STR 2
1. Install cluster (Ambari 2.1.3) with HDFS
2. Remove property from hdfs-site (for example {{/var/lib/ambari-server/resources/scripts/configs.sh delete localhost c1 hdfs-site dfs.block.access.token.enable}} )
3. Run Add Service Wizard, Select add storm

ER
Deleted properties do not appear in Advanced hdfs-site
AR
Deleted property are back


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 2b55ffb 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 41da879 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 1fa4e44 

Diff: https://reviews.apache.org/r/40389/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 40389: Deleted properties appear in Add Service Wizard

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40389/#review106864
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Лис. 17, 2015, 2:34 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40389/
> -----------------------------------------------------------
> 
> (Updated Лис. 17, 2015, 2:34 після полудня)
> 
> 
> Review request for Ambari, Nate Cole and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13922
>     https://issues.apache.org/jira/browse/AMBARI-13922
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR 1
> 1. Install cluster (Ambari 2.1.3) with HDFS
> 2. Enable HA (property dfs.namenode.rpc-address is deleted)
> 3. Run Add Service Wizard, select add storm
> 
> STR 2
> 1. Install cluster (Ambari 2.1.3) with HDFS
> 2. Remove property from hdfs-site (for example {{/var/lib/ambari-server/resources/scripts/configs.sh delete localhost c1 hdfs-site dfs.block.access.token.enable}} )
> 3. Run Add Service Wizard, Select add storm
> 
> ER
> Deleted properties do not appear in Advanced hdfs-site
> AR
> Deleted property are back
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 2b55ffb 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 41da879 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 1fa4e44 
> 
> Diff: https://reviews.apache.org/r/40389/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 40389: Deleted properties appear in Add Service Wizard

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40389/#review106874
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Nov. 17, 2015, 9:34 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40389/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 9:34 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13922
>     https://issues.apache.org/jira/browse/AMBARI-13922
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR 1
> 1. Install cluster (Ambari 2.1.3) with HDFS
> 2. Enable HA (property dfs.namenode.rpc-address is deleted)
> 3. Run Add Service Wizard, select add storm
> 
> STR 2
> 1. Install cluster (Ambari 2.1.3) with HDFS
> 2. Remove property from hdfs-site (for example {{/var/lib/ambari-server/resources/scripts/configs.sh delete localhost c1 hdfs-site dfs.block.access.token.enable}} )
> 3. Run Add Service Wizard, Select add storm
> 
> ER
> Deleted properties do not appear in Advanced hdfs-site
> AR
> Deleted property are back
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 2b55ffb 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 41da879 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 1fa4e44 
> 
> Diff: https://reviews.apache.org/r/40389/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>