You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/06/24 00:52:02 UTC
[GitHub] [helix] kaisun2000 commented on pull request #1119: Add sync() call first for new session handling (#1118)
kaisun2000 commented on pull request #1119:
URL: https://github.com/apache/helix/pull/1119#issuecomment-648518387
This is the core logic here, interface change would be added next.
1/ We don't call sync in Zookeeper client event thread.
2/ We don't use handle connectionLossKeeperException. In fact, sync() does not throw this exception. Maybe it should throw this exception.
3/ Sync() has only async version. We don't wait till it return successfully before proceeding. This is intentional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org